{"id":15622,"url":"https://patchwork.libcamera.org/api/1.1/covers/15622/?format=json","web_url":"https://patchwork.libcamera.org/cover/15622/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220406075859.3857121-1-naush@raspberrypi.com>","date":"2022-04-06T07:58:56","name":"[libcamera-devel,v4,0/3] Dequeue timeout","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"mbox":"https://patchwork.libcamera.org/cover/15622/mbox/","series":[{"id":3031,"url":"https://patchwork.libcamera.org/api/1.1/series/3031/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3031","date":"2022-04-06T07:58:56","name":"Dequeue timeout","version":4,"mbox":"https://patchwork.libcamera.org/series/3031/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/15622/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 253F9C0F1B\n\tfor ;\n\tWed, 6 Apr 2022 07:59:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4DB7865642;\n\tWed, 6 Apr 2022 09:59:06 +0200 (CEST)","from mail-wm1-x333.google.com (mail-wm1-x333.google.com\n\t[IPv6:2a00:1450:4864:20::333])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 55217604B8\n\tfor ;\n\tWed, 6 Apr 2022 09:59:04 +0200 (CEST)","by mail-wm1-x333.google.com with SMTP id n35so900374wms.5\n\tfor ;\n\tWed, 06 Apr 2022 00:59:04 -0700 (PDT)","from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:eedb:32e2:e3d4:3bfa])\n\tby smtp.gmail.com with ESMTPSA id\n\t14-20020a056000154e00b00203f8adde0csm17235503wry.32.2022.04.06.00.59.02\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 06 Apr 2022 00:59:03 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649231946;\n\tbh=AoMTlmx4nkNH6r9byOirgwVUnZGXqEjyvdMGb0Oe3zs=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=rE6tjrJee6nDsnATPrRstybHmUBCVX+uQ/Aebcv4sZaA+xuz1526iHZr2c3Gb3JEV\n\tV1quF4Xb85uJl1JAVoQ7haD0XtjqABeTRYsyEmTLEWj7SZVeBdeYPSNsKnM3UoXhmA\n\t+HP/S8MkW8Acsv7er2iz8U3vBbrqdf6IDWrTc/O9Z1s6wr0iWWJY11p7j4J+80y6bb\n\toFUdZ0McjFk8ufylIZzEmhiUbZ66rNiK7RrFlQ9my0n85bXNEGNVaH5NEqyQWVx0zF\n\tQ5CPC4K1qk1ow1tFMOq2k2/1wU1/cbdC5NU6wktubcOlsbF7rXkCLW9QaW9e6A7dhT\n\tmPAKxARRFFqWw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=+A7/LuGt/ju2YrP6poOqjI64B2Oxj0q3InksCIwp1Kg=;\n\tb=RHehl6k6XZkHeEuKdF5Avrkce2ABgs/xcddpRPOABfIxoiAsrA5ob1rXIvr9yBgJ4v\n\tl6TbbWJaydR5Lx4VhpQ2YKd8HJyLYG3fVxummUBvsnsKMkOgh8pGNUcFawb/GwaDEAGX\n\tRLqFwOcsbsj6EKmo6r6rl5TK2KpKkmrRyolLke3yXjrym8vWiA1jKYVXTauLS+SCVbjw\n\t8eDwqTbDBa1GBDju4kvX2+1ZUuDwpTX4zCUXf3ktIQEODRjoFEHQ7XjTRFi0MtECdOMY\n\t0j2pPXQyqxpGmoGzEFjOswC4rCsnKfh+dByS+k6kOlgpwcp8xuR81O37m62Ow446pa9K\n\tH9RQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"RHehl6k6\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=+A7/LuGt/ju2YrP6poOqjI64B2Oxj0q3InksCIwp1Kg=;\n\tb=bXKF18rnfXwUFWkt1VgMIjLBP86kx4nDIzu4upx1r8g1hPxH4PhPPuJvS821QK92Yo\n\tUWE15pIbZx4Cf7OnoDhkTqh3a78QDjKaGrPxsgehCsuW7JVyRl9wpSySF0d4RQu5T+42\n\tWKdXMY5LR1x+NOHk8kJNQi0MMnJYrjt6+hKcD5Mfipdj1jhGpbL942nYw8N3t/LVwKoF\n\thahU8DP+SoE4DxNNI9v2dF2IGuLOy6UGHAN/k7bMxdKz9TZkNxL6NuLampwMBbcJ4MTF\n\tY4Z1Ba585RlxkraaouzdcMeFoFF9KL3AnCM4t40CjZvAQqIxrLKY2HbLJvoPgu/IK9N2\n\tredA==","X-Gm-Message-State":"AOAM532qQd05hVLmnKV+BfqqBuNHIMvgqjgRqyKraNL4IkwTbWAHeKS1\n\tH2Mz59J02hzDqYBbSDs6zSqe+ijrPD/Tkw==","X-Google-Smtp-Source":"ABdhPJz0/sBhoz6XwbZOqFrGOyAClPxIPFg44L27thQFh/htCRPsch00cyiUl+/+0H1PWaXrQfBKvg==","X-Received":"by 2002:a05:600c:35cc:b0:38c:6d25:f4ad with SMTP id\n\tr12-20020a05600c35cc00b0038c6d25f4admr6239717wmq.127.1649231943700; \n\tWed, 06 Apr 2022 00:59:03 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 6 Apr 2022 08:58:56 +0100","Message-Id":"<20220406075859.3857121-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 0/3] Dequeue timeout","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hi,\n\nI've updated this patch with all the suggested changes for version 4. In particular,\nI've switched back to using utils::Duration to store the timeout value in the\nv4l2_videodevice class. However, because of this change, I have to do a slightly\nawkward cast when setting the Timer value:\n\nwatchdog_.start(std::chrono::duration_cast(watchdogDuration_));\n\nThis is becase the base type of utils::Duration whereas std::chrono::milliseconds\nuses an integer, and you are not allowed an implicit conversion between the two.\nOnce we switch utils::Duration to use an integer base type, implicit conversions\nwill be possible, and we can get rid of the above cast. Does that seem reasonable?\n\nThanks,\nNaush\n\nKieran Bingham (1):\n test: v4l2_videodevice: Verify the Dequeue Watchdog\n\nNaushir Patuck via libcamera-devel (2):\n libcamera: v4l2_videodevice: Add a dequeue timer\n pipeline: raspberrypi: Add a Unicam dequeue timeout\n\n include/libcamera/internal/v4l2_videodevice.h | 10 ++\n include/libcamera/ipa/raspberrypi.mojom | 1 +\n src/ipa/raspberrypi/raspberrypi.cpp | 2 +\n .../pipeline/raspberrypi/raspberrypi.cpp | 15 +++\n src/libcamera/v4l2_videodevice.cpp | 55 +++++++++++\n test/v4l2_videodevice/dequeue_watchdog.cpp | 96 +++++++++++++++++++\n test/v4l2_videodevice/meson.build | 1 +\n 7 files changed, 180 insertions(+)\n create mode 100644 test/v4l2_videodevice/dequeue_watchdog.cpp"}