{"id":15384,"url":"https://patchwork.libcamera.org/api/1.1/covers/15384/?format=json","web_url":"https://patchwork.libcamera.org/cover/15384/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220224151113.109858-1-jeanmichel.hautbois@ideasonboard.com>","date":"2022-02-24T15:11:09","name":"[libcamera-devel,v4,0/4] ipa: ipu3: Misc clean up","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/15384/mbox/","series":[{"id":2940,"url":"https://patchwork.libcamera.org/api/1.1/series/2940/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2940","date":"2022-02-24T15:11:09","name":"ipa: ipu3: Misc clean up","version":4,"mbox":"https://patchwork.libcamera.org/series/2940/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/15384/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A5819BE08A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 24 Feb 2022 15:11:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 00B9361154;\n\tThu, 24 Feb 2022 16:11:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C0E38601F9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 24 Feb 2022 16:11:18 +0100 (CET)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:ce74:6df2:4b76:b230])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 682C1DD;\n\tThu, 24 Feb 2022 16:11:18 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Yz7pBFE5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1645715478;\n\tbh=/SyoV1xT3wBJzNgMxrWgLhXwXIANCZ3lQXJ0eY8KNHc=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Yz7pBFE5DmWEnMoyDm0fV+ulHG6L+p3XF7a/wLQb7cJtQjIGrPYsUGIrxqqn7lO0V\n\t8R57owlVtpg7yyaD+BsuEvD0w67aksea2B/NJuUvfqjyzRW+CIIRvXP15TiYUvWa7R\n\tijHo6JS3aOhzRYAh0H5ioX2kSkqRxVNFspD1o5VU=","From":"Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 24 Feb 2022 16:11:09 +0100","Message-Id":"<20220224151113.109858-1-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 0/4] ipa: ipu3: Misc clean up","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Hello,\n\nWhile working on AGC porting from IPU3 to RkISP1, a few minor changes\nwere proposed to clean the variables and function usage.\n\nReport those changes in IPU3.\n\nIn v2:\n  - Correct the filterExposure() calculation to use the same as RkISP1\n  - Rewrite some comments\n  - Remove the caching of analogue gain and exposure\n\nIn v3:\n  - Remove all local references to lineDuration_ and use the context\n    everywhere in IPAIPU3\n\nIn v4:\n  - Remove lineDuration calculation in IPU3Agc::configure\n  - Clean only frameContext at configure()\n  - Add clamping of gain values in IPU3Awb\n\nJean-Michel Hautbois (4):\n  ipa: ipu3: Return filtered value\n  ipa: ipu3: Shorten exposure and gain lines\n  ipa: ipu3: agc: Introduce lineDuration in IPASessionConfiguration\n  ipa: ipu3: awb: Clamp gain values\n\n src/ipa/ipu3/algorithms/agc.cpp | 100 +++++++++++++++++---------------\n src/ipa/ipu3/algorithms/agc.h   |   6 +-\n src/ipa/ipu3/algorithms/awb.cpp |   8 +++\n src/ipa/ipu3/ipa_context.cpp    |   8 +++\n src/ipa/ipu3/ipa_context.h      |   4 ++\n src/ipa/ipu3/ipu3.cpp           |  35 ++++++-----\n 6 files changed, 96 insertions(+), 65 deletions(-)"}