{"id":15376,"url":"https://patchwork.libcamera.org/api/1.1/covers/15376/?format=json","web_url":"https://patchwork.libcamera.org/cover/15376/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220224113347.80001-1-jeanmichel.hautbois@ideasonboard.com>","date":"2022-02-24T11:33:42","name":"[libcamera-devel,v3,0/5] IPA RkISP1 awb and misc improvements","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/15376/mbox/","series":[{"id":2937,"url":"https://patchwork.libcamera.org/api/1.1/series/2937/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2937","date":"2022-02-24T11:33:42","name":"IPA RkISP1 awb and misc improvements","version":3,"mbox":"https://patchwork.libcamera.org/series/2937/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/15376/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A5435BF415\n\tfor ;\n\tThu, 24 Feb 2022 11:33:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7EE316115E;\n\tThu, 24 Feb 2022 12:33:54 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E822D601F9\n\tfor ;\n\tThu, 24 Feb 2022 12:33:52 +0100 (CET)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:ce74:6df2:4b76:b230])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 807DBDD;\n\tThu, 24 Feb 2022 12:33:52 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SrN4mIhU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1645702432;\n\tbh=OTiqTWZwBz/30EYUkdDHHXIQj+tG+67Mkcu6A+ecnjc=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=SrN4mIhUM2IUip1qUSzQ4xYRWzzEDWJQrJbLZO1Xs2JWVilrvBPxzQgV9O9y4DB5c\n\tWelPcwLjmhclrwdiS1e7MdZTaiuhk8u3enZ+wOQdOhXMd2GTSD3ryiSlTrDiH6x8x8\n\teHLGMYGKqJkt/DJgn86FKTMVGivCdNoU/cI9FeD0=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 24 Feb 2022 12:33:42 +0100","Message-Id":"<20220224113347.80001-1-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 0/5] IPA RkISP1 awb and misc\n\timprovements","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello,\n\nThis series introduces several algorithms or tuning parameters for the\nRkISP1 IPA.\n\nThe first algorithm is the black level correction. The output is washed\nout if no black correction is applied. It uses the tuning values from\nthe imx219 data file in RPi.\n\nPatch 3/5 introduced in v3 makes the Histogram class able to use const\nuint32_t arrays.\n\nPatch 4/5 introduces the histogram IQ mean estimation as for the IPU3\nand uses the maximum of the relative luminance gain and the iqMean gain\nto determine the shutter speed and analogue gain to apply.\n\nNow, patch 5/5 can estimate the AWB gains to apply on the red and blue\nchannels. The RkISP1 could theoretically give us the red, green and blue\nmean values for the current frame, but the kernel seems to lack support\nfor this. Use the YCrCb estimation instead, and convert the values to\nRGB before estimating the gains. We don't have a grid of average values,\nonly a global mean for each channel.\n\nI have removed two algorithms from this series: sensor degamma and\ncrosstalk matrix. Those need a bit more work (sdg curve may be the wrong\none according to the previous review, and the crosstalk matrix is not a\ntuned one).\n\nI have made some captures (qcam seems to invert width and height when\nsaving the image though):\n\n[1]: agc only (current master): https://snipboard.io/dFO23J.jpg\n[2]: [1] with histogram and black level: https://snipboard.io/fd9zC2.jpg\n[3]: [2] with awb: https://snipboard.io/Sp9Ei6.jpg\n\nThis is the state with this v2 series applied on top of master.\n\nAnd for the record, I picked the previous sdg and ctk algorithms to\ncapture with those:\n[4]: [3] with sensor degamma: https://snipboard.io/5QO46g.jpg\n[5]: [4] with crosstalk matrix: https://snipboard.io/tDOV7l.jpg\n\nJean-Michel Hautbois (5):\n ipa: rkisp1: Use frame counter for the request queued\n ipa: rkisp1: Introduce Black Level Correction\n ipa: libipa: Histogram: Constify the constructor span\n ipa: rkisp1: agc: Add a histogram-based gain\n ipa: rkisp1: Introduce AWB\n\n src/ipa/libipa/histogram.cpp | 2 +-\n src/ipa/libipa/histogram.h | 2 +-\n src/ipa/rkisp1/algorithms/agc.cpp | 94 ++++++++++++--\n src/ipa/rkisp1/algorithms/agc.h | 6 +-\n src/ipa/rkisp1/algorithms/awb.cpp | 180 ++++++++++++++++++++++++++\n src/ipa/rkisp1/algorithms/awb.h | 33 +++++\n src/ipa/rkisp1/algorithms/blc.cpp | 57 ++++++++\n src/ipa/rkisp1/algorithms/blc.h | 30 +++++\n src/ipa/rkisp1/algorithms/meson.build | 2 +\n src/ipa/rkisp1/ipa_context.cpp | 40 +++++-\n src/ipa/rkisp1/ipa_context.h | 21 ++-\n src/ipa/rkisp1/rkisp1.cpp | 7 +\n 12 files changed, 454 insertions(+), 20 deletions(-)\n create mode 100644 src/ipa/rkisp1/algorithms/awb.cpp\n create mode 100644 src/ipa/rkisp1/algorithms/awb.h\n create mode 100644 src/ipa/rkisp1/algorithms/blc.cpp\n create mode 100644 src/ipa/rkisp1/algorithms/blc.h"}