{"id":1493,"url":"https://patchwork.libcamera.org/api/1.1/covers/1493/?format=json","web_url":"https://patchwork.libcamera.org/cover/1493/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190621161401.28337-1-kieran.bingham@ideasonboard.com>","date":"2019-06-21T16:13:52","name":"[libcamera-devel,RFC,v2,0/9] Libcamera Controls","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/1493/mbox/","series":[{"id":370,"url":"https://patchwork.libcamera.org/api/1.1/series/370/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=370","date":"2019-06-21T16:13:52","name":"Libcamera Controls","version":2,"mbox":"https://patchwork.libcamera.org/series/370/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/1493/comments/","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9230F600F7\n\tfor ;\n\tFri, 21 Jun 2019 18:14:06 +0200 (CEST)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EE91267;\n\tFri, 21 Jun 2019 18:14:05 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1561133646;\n\tbh=hshEvx0Hz24h/yBqBPWCdWDVvVFTC1jZdxe8Ca7TaV4=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=nbWGM9vYYTDr5xnEax088blcY55ojddjRFYVBYciKNHBD5K2vVyN+w5MFAMpdCtyJ\n\tcxFQad2Yf6e0auXOD1Yq31Je0+EsdGXEl+4hvv7/JSfPIZzILj1+fm94QmHHee0fRU\n\tx5iTle1Uu72fCJ/0g3DK9R9j10F3PKTSJ/F2IGI4=","From":"Kieran Bingham ","To":"LibCamera Devel ","Date":"Fri, 21 Jun 2019 17:13:52 +0100","Message-Id":"<20190621161401.28337-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.20.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH v2 0/9] Libcamera Controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 21 Jun 2019 16:14:06 -0000"},"content":"V2 of LibCamera controls, now with extracted Value class and a long list of\nundocumented todos.\n\nThis series is based upon Jacopo's v5 of V4L2Controls.\n\n - ControlValue class is now in it's own reusable Value class.\n This should be re-usable somewhat like a QT QVariant ...\n\n - ControlList\n Controls are now simply an association of a ControlInfo (or ID) and a Value.\n The ControlList is a custom wrapper of an unordered_map to pass these around.\n\n\nKnown todos / issues:\n - I still need to look at querying ControlInfo attributes\n\n - Currently I think a ControlInfo structure is created everytime an entry is\n added to the ControlList, and this likely isn't as efficient as I'd like\n - Min/Max values in ControlInfo are currently unset and un-used - but that\n should change.\n\n - I feel like it would be nice to have a better representation of a single\n control, rather than just a ControlInfo,Value pair. I have a custom Control\n class to experiment with but that is not utilsed by this series.\n I'm not sure how I'd change the iterators to use this anyway yet.\n\n - This series does not aim to represent MetaData as such yet. That might be\n similar and might be possible to use a 'ControlList' but it's not clear yet.\n\n - As yet there is not a facility to obtain a list of all controls from the\n V4L2 layer, and as such I have not yet implemented any means of finding\n a complete set of controls aavilable to a particular Camera.\n\n \n \nKieran Bingham (9):\n libcamera: Value: Provide abstract value class\n libcamera: test: Add Value tests\n libcamera: controls: Introduce Control structures\n libcamera: test: Add ControlInfo tests\n libcamera: Implement a ControlList\n libcamera: request: Add a ControlList\n libcamera: test: Add ControlList tests\n [PoC] UVCPipelineHandler: Set Controls\n [PoC] QCam: Control demo: A SineWave Brightness\n\n include/libcamera/controls.h | 99 ++++++++++\n include/libcamera/meson.build | 2 +\n include/libcamera/request.h | 3 +\n include/libcamera/value.h | 63 ++++++\n src/libcamera/controls.cpp | 288 ++++++++++++++++++++++++++++\n src/libcamera/meson.build | 2 +\n src/libcamera/pipeline/uvcvideo.cpp | 43 ++++-\n src/libcamera/request.cpp | 10 +\n src/libcamera/value.cpp | 226 ++++++++++++++++++++++\n src/qcam/main_window.cpp | 16 ++\n test/controls.cpp | 139 ++++++++++++++\n test/meson.build | 2 +\n test/value.cpp | 82 ++++++++\n 13 files changed, 974 insertions(+), 1 deletion(-)\n create mode 100644 include/libcamera/controls.h\n create mode 100644 include/libcamera/value.h\n create mode 100644 src/libcamera/controls.cpp\n create mode 100644 src/libcamera/value.cpp\n create mode 100644 test/controls.cpp\n create mode 100644 test/value.cpp"}