{"id":14897,"url":"https://patchwork.libcamera.org/api/1.1/covers/14897/?format=json","web_url":"https://patchwork.libcamera.org/cover/14897/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211130155600.2203123-1-hiroh@chromium.org>","date":"2021-11-30T15:55:48","name":"[libcamera-devel,v3,00/12] Introduce clang thread safety annotations","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/1.1/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"mbox":"https://patchwork.libcamera.org/cover/14897/mbox/","series":[{"id":2785,"url":"https://patchwork.libcamera.org/api/1.1/series/2785/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2785","date":"2021-11-30T15:55:48","name":"Introduce clang thread safety annotations","version":3,"mbox":"https://patchwork.libcamera.org/series/2785/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/14897/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8289FBF415\n\tfor ;\n\tTue, 30 Nov 2021 15:56:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A028E6071B;\n\tTue, 30 Nov 2021 16:56:10 +0100 (CET)","from mail-pg1-x532.google.com (mail-pg1-x532.google.com\n\t[IPv6:2607:f8b0:4864:20::532])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 35B27605C4\n\tfor ;\n\tTue, 30 Nov 2021 16:56:09 +0100 (CET)","by mail-pg1-x532.google.com with SMTP id s37so10567583pga.9\n\tfor ;\n\tTue, 30 Nov 2021 07:56:09 -0800 (PST)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:c90a:5a53:b139:1336])\n\tby smtp.gmail.com with ESMTPSA id\n\tpc10sm3510283pjb.9.2021.11.30.07.56.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 30 Nov 2021 07:56:06 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"OLBPLAPw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=SWpHN9d0Ewfikdi4B4yPAUP0Jnd4BjI4uRqAYVw1fdI=;\n\tb=OLBPLAPwt/+iCpBBXTopg9mLRxPp+kklnWuc2awTIaSBkVnL5t0epXXnz4RijSAouq\n\tHJpNz+qf+j8RxWrK8yxfWgkwFQIm+XnaxwYXsrWn6uxLkCndqQAhdBCXgnkaUvr/YmUD\n\txPhzATCX4Cj2XAfGrOWus3UmzZ3pXyK+tfgpg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=SWpHN9d0Ewfikdi4B4yPAUP0Jnd4BjI4uRqAYVw1fdI=;\n\tb=x5sVU2CZ3mTr8O+DBxm2prBkF5JeBAtQ6JDONEipcrhRiEQyu+eXD849ES2quYfrIi\n\to+HVNCkcKq6ECzJELIDKUTqIhcjtaEIuDSr42EYIyfZqJpu34/N2WQNVQKUMaEUhNa/t\n\t25dYadX2hc4hWL9fFutirGa6AaStjnyQGGSTeDOu417OxMVFmVDTZ2PjDNBgvAcZgSPa\n\tCp9wdj2S0VQtsmmxP0Dqi9wGd1o1YEv9yyS7+Vd8pfy6porcGoaUFJsKvjFTLwOEL7pR\n\tAfRcOZ5cLQzfI+PCYr5yw8oEJ5z+JFjUHQMzqzvCmVAvxDDD4TvW/nzmRGo7SYw/ESLo\n\t7aQg==","X-Gm-Message-State":"AOAM530okAAAk6FFqXL8pqjksrLwfvswAlXyLFDwYSuXGJoSLG7yBiVq\n\tvCL3Ydxk+eCHHEI9kmhGKyhyEb1OJU385g==","X-Google-Smtp-Source":"ABdhPJy1LkmFM4KM38nriTkYDGcMN/Gp4qtKAJ1YkMqEk9m76O5H7c/BlCJowrcBcqVEUC+TwABy/w==","X-Received":"by 2002:a63:e04f:: with SMTP id\n\tn15mr41446070pgj.31.1638287767088; \n\tTue, 30 Nov 2021 07:56:07 -0800 (PST)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 1 Dec 2021 00:55:48 +0900","Message-Id":"<20211130155600.2203123-1-hiroh@chromium.org>","X-Mailer":"git-send-email 2.34.0.rc2.393.gf8c9666880-goog","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 00/12] Introduce clang thread safety\n\tannotations","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This introduces clang thread safety annotations and applies it\nto libcamera Android HAL adaptation layer. It is necessary to add\nnew classes that wrap std::mutex, std::unique_lock and\nstd::condition_variable with the annotations. It is because no\nC++ standard library annotates all the mutex classes today.\nlibstdc++ doesn't annotate any classes. libc++ annotates for\nstd::mutex, std::lock_guard and std::scoped_lock, but doesn't for\nstd::unique_lock.\n\nTherefore it is possible to use std::mutex if libc++ is used.\nAlthoug I don't do so In this patch series because the existing\ncode using std::mutex is not annotated yet.\n\nDocument: https://clang.llvm.org/docs/ThreadSafetyAnalysis.html\n\nChange in v3:\n* Addresses comments from Laurent\n* 05/12: Add documentation about Mutex, MutexLocker and ConditionVariable\n* 06/12: Clean up include headers of thread.h and mutex.h\n\nHirokazu Honda (12):\n libcamera: base: Introduce ConditionVariable\n android: Consolidate mutex classes to Mutex and MutexLocker\n v4l2: Consolidate mutex classes to Mutex and MutexLocker\n libcamera: base: Add thread safety annotation macros\n libcamera: base: Add mutex classes with thread safety annotations\n libcamera: Correct include headers for Mutex classes\n android: camera_hal_manager: Add thread safety annotation\n android: camera_stream: Protect buffers initialization by mutex_\n android: camera_stream: Add thread safety annotation\n android: camera_device: Fix variables access without protection\n android: camera_device: Add thread safety annotation\n android: camera_request: Add thread safety annotation\n\n include/libcamera/base/meson.build | 2 +\n include/libcamera/base/mutex.h | 131 ++++++++++++++++++++\n include/libcamera/base/semaphore.h | 6 +-\n include/libcamera/base/thread.h | 4 -\n include/libcamera/base/thread_annotations.h | 80 ++++++++++++\n meson.build | 1 +\n src/android/camera_device.cpp | 9 +-\n src/android/camera_device.h | 18 +--\n src/android/camera_hal_manager.h | 14 +--\n src/android/camera_request.h | 8 +-\n src/android/camera_stream.cpp | 15 +--\n src/android/camera_stream.h | 16 +--\n src/libcamera/base/meson.build | 1 +\n src/libcamera/base/mutex.cpp | 121 ++++++++++++++++++\n src/libcamera/base/semaphore.cpp | 1 -\n src/libcamera/base/signal.cpp | 3 +-\n src/libcamera/base/thread.cpp | 14 +--\n src/libcamera/camera_manager.cpp | 4 +-\n src/v4l2/v4l2_camera.h | 6 +-\n src/v4l2/v4l2_camera_proxy.cpp | 8 +-\n src/v4l2/v4l2_camera_proxy.h | 5 +-\n 21 files changed, 399 insertions(+), 68 deletions(-)\n create mode 100644 include/libcamera/base/mutex.h\n create mode 100644 include/libcamera/base/thread_annotations.h\n create mode 100644 src/libcamera/base/mutex.cpp\n\n--\n2.34.0.rc2.393.gf8c9666880-goog"}