{"id":14815,"url":"https://patchwork.libcamera.org/api/1.1/covers/14815/?format=json","web_url":"https://patchwork.libcamera.org/cover/14815/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211128235752.10836-1-laurent.pinchart@ideasonboard.com>","date":"2021-11-28T23:57:35","name":"[libcamera-devel,v3,00/17] libcamera: Introduce UniqueFD","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/14815/mbox/","series":[{"id":2768,"url":"https://patchwork.libcamera.org/api/1.1/series/2768/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2768","date":"2021-11-28T23:57:35","name":"libcamera: Introduce UniqueFD","version":3,"mbox":"https://patchwork.libcamera.org/series/2768/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/14815/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 48DCFBF415\n\tfor ;\n\tSun, 28 Nov 2021 23:58:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 55FC06058E;\n\tMon, 29 Nov 2021 00:58:22 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 700AB6011D\n\tfor ;\n\tMon, 29 Nov 2021 00:58:21 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D694F730;\n\tMon, 29 Nov 2021 00:58:20 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fAzhHepj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1638143901;\n\tbh=wetFX2rviG7HpHG+uxMrA5spNc8lqyMZ7g7jLF5AmSo=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=fAzhHepj5305uER21zEjwtvJRWtSXKS9/LWZlzqQs/61FSrkaHla8ymESyjsMFV2w\n\tSU2wDdUtnnZUjXID4js6CPBgw8ab+7ZHDsXD6Dy2QSGC/jPLSo5LNDCXuLvx0ZXzbd\n\t9VNA/vQo3bCBMPVyLUWNujpoG9DHeWc3/uBhQtUw=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 29 Nov 2021 01:57:35 +0200","Message-Id":"<20211128235752.10836-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 00/17] libcamera: Introduce UniqueFD","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello,\n\nThis patch series is a continuation of Hiro's work on the ScopedFD class\n([1]). The class is a std::unique_ptr<>-like wrapper around file\ndescriptors, which complements the existing shared-ownership\nFileDescriptor.\n\nCompared to v2, the main changes are a rename of ScopedFD to UniqueFD,\nand to match that, of FileDescriptor to SharedFD. Patches 01/17 to 03/17\nrefactor headers a little bit first, patch 05/17 is new too and adds a\nunit test for the UniqueFD class, and patch 07/17 changes the\nFileDescriptor::dup() function to make it easier to interoperate with\nUniqueFD. Other minor changes are listed in the changelog of individual\npatches.\n\n[1] https://patchwork.libcamera.org/project/libcamera/list/?series=2115\n\nHirokazu Honda (11):\n libcamera: base: Introduce UniqueFD\n libcamera: base: file_descriptor: Add constructor from UniqueFD\n libcamera: event_dispatcher_poll: Manage fd by UniqueFD\n libcamera: file: Manage fd by UniqueFD\n libcamera: ipc_unixsocket: Use UniqueFD for a file descriptor\n libcamera: process: Manage pipe fds by UniqueFD\n libcamera: media_device: Manage fd by UniqueFD\n libcamera: v4l2_device: Use UniqueFD for a file descriptor\n libcamera: v4l2_videodevice: Use fd for a file descriptor\n libcamera: pipeline: raspberrypi: DmaHeaps: Use UniqueFD for a file\n descriptor\n v4l2: v4l2_camera: Return int in getBufferFd()\n\nLaurent Pinchart (6):\n libcamera: Move compiler.h to base/\n libcamera: Move file_descriptor.h to base/\n libcamera: base: file_descriptor: Move inode() function to File class\n test: Add UniqueFD test\n libcamera: base: file_descriptor: Return UniqueFD from dup()\n libcamera: base: Rename FileDescriptor to SharedFD\n\n include/libcamera/{ => base}/compiler.h | 0\n .../libcamera/base/event_dispatcher_poll.h | 3 +-\n include/libcamera/base/file.h | 8 +-\n include/libcamera/base/meson.build | 3 +\n .../{file_descriptor.h => base/shared_fd.h} | 26 +-\n include/libcamera/base/unique_fd.h | 69 +++++\n include/libcamera/framebuffer.h | 5 +-\n include/libcamera/geometry.h | 2 +-\n .../libcamera/internal/ipa_data_serializer.h | 40 +--\n include/libcamera/internal/ipc_pipe.h | 9 +-\n include/libcamera/internal/ipc_unixsocket.h | 7 +-\n include/libcamera/internal/media_device.h | 3 +-\n include/libcamera/internal/process.h | 4 +-\n include/libcamera/internal/v4l2_device.h | 9 +-\n include/libcamera/internal/v4l2_videodevice.h | 4 +-\n include/libcamera/ipa/core.mojom | 6 +-\n include/libcamera/ipa/raspberrypi.mojom | 2 +-\n include/libcamera/meson.build | 2 -\n src/android/camera_device.cpp | 2 +-\n src/ipa/raspberrypi/raspberrypi.cpp | 4 +-\n src/libcamera/base/event_dispatcher_poll.cpp | 11 +-\n src/libcamera/base/file.cpp | 48 +++-\n src/libcamera/base/meson.build | 2 +\n src/libcamera/base/shared_fd.cpp | 262 +++++++++++++++++\n src/libcamera/base/unique_fd.cpp | 123 ++++++++\n src/libcamera/file_descriptor.cpp | 272 ------------------\n src/libcamera/framebuffer.cpp | 11 +-\n src/libcamera/ipa_data_serializer.cpp | 100 +++----\n src/libcamera/ipc_pipe.cpp | 4 +-\n src/libcamera/ipc_pipe_unixsocket.cpp | 8 +-\n src/libcamera/ipc_unixsocket.cpp | 43 +--\n src/libcamera/media_device.cpp | 36 +--\n src/libcamera/meson.build | 1 -\n .../pipeline/raspberrypi/dma_heaps.cpp | 28 +-\n .../pipeline/raspberrypi/dma_heaps.h | 10 +-\n .../pipeline/raspberrypi/raspberrypi.cpp | 11 +-\n src/libcamera/process.cpp | 16 +-\n src/libcamera/v4l2_device.cpp | 23 +-\n src/libcamera/v4l2_videodevice.cpp | 51 ++--\n src/v4l2/v4l2_camera.cpp | 6 +-\n src/v4l2/v4l2_camera.h | 4 +-\n src/v4l2/v4l2_camera_proxy.cpp | 6 +-\n test/ipc/unixsocket.cpp | 14 +-\n test/ipc/unixsocket_ipc.cpp | 8 +-\n test/meson.build | 3 +-\n .../ipa_data_serializer_test.cpp | 14 +-\n test/{file-descriptor.cpp => shared-fd.cpp} | 47 ++-\n test/unique-fd.cpp | 220 ++++++++++++++\n .../module_ipa_proxy.cpp.tmpl | 2 +-\n .../module_ipa_proxy.h.tmpl | 2 +-\n .../module_ipa_proxy_worker.cpp.tmpl | 13 +-\n .../libcamera_templates/proxy_functions.tmpl | 2 +-\n .../libcamera_templates/serializer.tmpl | 22 +-\n .../generators/mojom_libcamera_generator.py | 6 +-\n 54 files changed, 1030 insertions(+), 607 deletions(-)\n rename include/libcamera/{ => base}/compiler.h (100%)\n rename include/libcamera/{file_descriptor.h => base/shared_fd.h} (52%)\n create mode 100644 include/libcamera/base/unique_fd.h\n create mode 100644 src/libcamera/base/shared_fd.cpp\n create mode 100644 src/libcamera/base/unique_fd.cpp\n delete mode 100644 src/libcamera/file_descriptor.cpp\n rename test/{file-descriptor.cpp => shared-fd.cpp} (80%)\n create mode 100644 test/unique-fd.cpp\n\n\nbase-commit: cb1de3990787c2e4e3b4a214758157b2869482cc"}