{"id":14649,"url":"https://patchwork.libcamera.org/api/1.1/covers/14649/?format=json","web_url":"https://patchwork.libcamera.org/cover/14649/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20211119111654.68445-1-jeanmichel.hautbois@ideasonboard.com>","date":"2021-11-19T11:16:46","name":"[libcamera-devel,v1,0/8] Introduce AGC for RkISP1","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/14649/mbox/","series":[{"id":2735,"url":"https://patchwork.libcamera.org/api/1.1/series/2735/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2735","date":"2021-11-19T11:16:46","name":"Introduce AGC for RkISP1","version":1,"mbox":"https://patchwork.libcamera.org/series/2735/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/14649/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1FCADBF415\n\tfor ;\n\tFri, 19 Nov 2021 11:17:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB5F960376;\n\tFri, 19 Nov 2021 12:17:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 868F4600B5\n\tfor ;\n\tFri, 19 Nov 2021 12:16:59 +0100 (CET)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:db30:8e54:a96:9838])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 214961974;\n\tFri, 19 Nov 2021 12:16:59 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VL1XIrpa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1637320619;\n\tbh=odUArVZcYEb/2jodosjT0R5w50aIRqAXZlxXYlFw2hc=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=VL1XIrpa/Ddwru4H0YY/luKZV4huJXKcqN33XIQ/0BiseAC/UuKqoWzHGE1UxOuRr\n\thQrfi/X3YOCTLRhr01BcNV+cFXP3/F0BfW8jia0+Fawv9m7cwqjnCO3cBGjFsfSPui\n\tEhO8BzqBMxwhZY2r0MtRWNv1brPAdbDAwnY8XaOs=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 19 Nov 2021 12:16:46 +0100","Message-Id":"<20211119111654.68445-1-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v1 0/8] Introduce AGC for RkISP1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello,\n\nNow that AGC is working pretty nicely on IPU3, make it work on RkISP1\ntoo.\n\nFor that purpose, patches 1/8 to 5/8 reuse the concepts of Algorithm and\nIPAContext and make those part of th rkisp1 IPA. The effective sensor\ncontrols can then be reported.\n\nPatch 6/8 is a small adaptation of the IPU3 AGC: we reuse the relative\nluminance estimation, basing it on the Y mean measured by the ISP, and\nremoves the histogram based calculation for now.\n\nPatch 7/8 introduces a new prepare() call from the Algorithm class in\nAGC, and patch 8/8 is making it revision independant.\n\nJean-Michel Hautbois (8):\n ipa: rkisp1: Pass IPASettings at init call\n ipa: rkisp1: Instantiate CameraSensorHelper\n ipa: rkisp1: Introduce IPAContext\n ipa: ipu3: Introduce the Algorithm class\n ipa: rkisp1: Report and use sensor controls\n ipa: rkisp1: Introduce AGC\n ipa: rkisp1: agc: Introduce prepare call\n ipa: rkisp1: agc: Configure the number of cells used by HW\n\n include/libcamera/ipa/rkisp1.mojom | 6 +-\n src/ipa/ipu3/ipa_context.cpp | 3 +\n src/ipa/rkisp1/algorithms/agc.cpp | 258 +++++++++++++++++++++++\n src/ipa/rkisp1/algorithms/agc.h | 58 +++++\n src/ipa/rkisp1/algorithms/algorithm.cpp | 101 +++++++++\n src/ipa/rkisp1/algorithms/algorithm.h | 32 +++\n src/ipa/rkisp1/algorithms/meson.build | 6 +\n src/ipa/rkisp1/ipa_context.cpp | 102 +++++++++\n src/ipa/rkisp1/ipa_context.h | 52 +++++\n src/ipa/rkisp1/meson.build | 10 +-\n src/ipa/rkisp1/rkisp1.cpp | 120 ++++++-----\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 12 +-\n 12 files changed, 703 insertions(+), 57 deletions(-)\n create mode 100644 src/ipa/rkisp1/algorithms/agc.cpp\n create mode 100644 src/ipa/rkisp1/algorithms/agc.h\n create mode 100644 src/ipa/rkisp1/algorithms/algorithm.cpp\n create mode 100644 src/ipa/rkisp1/algorithms/algorithm.h\n create mode 100644 src/ipa/rkisp1/algorithms/meson.build\n create mode 100644 src/ipa/rkisp1/ipa_context.cpp\n create mode 100644 src/ipa/rkisp1/ipa_context.h\n\n\nbase-commit: ff89aa0185bfd141c72ed44bd2e5224df1465a3a"}