{"id":1424,"url":"https://patchwork.libcamera.org/api/1.1/covers/1424/?format=json","web_url":"https://patchwork.libcamera.org/cover/1424/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190613112046.25260-1-jacopo@jmondi.org>","date":"2019-06-13T11:20:40","name":"[libcamera-devel,v3,0/6] Add support for V4L2 Controls","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/cover/1424/mbox/","series":[{"id":357,"url":"https://patchwork.libcamera.org/api/1.1/series/357/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=357","date":"2019-06-13T11:20:40","name":"Add support for V4L2 Controls","version":3,"mbox":"https://patchwork.libcamera.org/series/357/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/1424/comments/","headers":{"Return-Path":"","Received":["from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 971FD61BD1\n\tfor ;\n\tThu, 13 Jun 2019 13:19:41 +0200 (CEST)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 24A68C000C;\n\tThu, 13 Jun 2019 11:19:40 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 13 Jun 2019 13:20:40 +0200","Message-Id":"<20190613112046.25260-1-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.21.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 0/6] Add support for V4L2 Controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 13 Jun 2019 11:19:41 -0000"},"content":"Hello,\n new V4L2 controls support iteration.\n\nThe patches are based on the in-review:\n[PATCH v4 0/2] libcamera: Introduce V4L2Device base class\n\nThis new version changes quite a few things, and is the result of the combined\nreview effort from everyone! Thanks a lot.\n\nMost notable changes:\n- Drop the support for compound and string controls\n- As a consequence drop template control values: everything is now stored\n in a long int\n- Decouple the control value from its information as Kieran has done for the\n libcamera control\n- Cache all controls info at V4L2 device open time to avoid extra calls to\n VIDIOC_QUERY_EXT_CTRL\n- Support creation on controls without value to be provided to getControls\n- Change V4L2Device::getControls() to accept a V4L2Controls as setControls()\n does.\n\nThe new interface is demonstrated by the last patch, and I report it here\na snippet:\n\n\t/* --- Get control values --- */\n\tV4L2Controls controls;\n\tcontrols.add(V4L2_CID_EXPOSURE);\n\tcontrols.add(V4L2_CID_ANALOGUE_GAIN);\n\tcio2->sensor_->getControls(&controls);\n\n\tfor (const V4L2Control &ctrl : controls) {\n\t\tunsigned int id = ctrl.id();\n\t\tV4L2ControlInfo *info = cio2->sensor_->getControlInfo(id);\n\t\tif (!info)\n\t\t\tcontinue;\n\n\t\tint val = controls.get(id);\n\t\tLOG(Error) << \"Control : \" << id << \" - name : \" << info->name()\n\t\t\t << \" - value: \" << val;\n\t}\n\n\t/* --- Set control values --- */\n\tcontrols.set(V4L2_CID_EXPOSURE, 2046);\n\tcontrols.set(V4L2_CID_ANALOGUE_GAIN, 1024);\n\tcio2->sensor_->setControls(&controls);\n\n\t/* --- Get control values back again and verify they have changed --- */\n\tcio2->sensor_->getControls(&controls);\n\tfor (const V4L2Control &ctrl : controls) {\n\t\tunsigned int id = ctrl.id();\n\t\tV4L2ControlInfo *info = cio2->sensor_->getControlInfo(id);\n\t\tif (!info)\n\t\t\tcontinue;\n\n\t\tint val = controls.get(id);\n\t\tLOG(Error) << \"Control : \" << id << \" - name : \" << info->name()\n\t\t\t << \" - value: \" << val;\n\t}\n\nThanks\n j\n\nJacopo Mondi (6):\n libcamera: Add V4L2Controls\n libcamera: v4l2_device: List controls at device open\n libcamera: v4l2_device: Implement get and set controls\n libcamera: camera_sensor: Add V4L2 control operations\n libcamera: ipu3: Set pipe_mode based on stream configuration\n [HACK] ipu3: Set and get a few sensor controls\n\n src/libcamera/camera_sensor.cpp | 58 +++++\n src/libcamera/include/camera_sensor.h | 6 +\n src/libcamera/include/v4l2_controls.h | 96 ++++++++\n src/libcamera/include/v4l2_device.h | 14 +-\n src/libcamera/meson.build | 1 +\n src/libcamera/pipeline/ipu3/ipu3.cpp | 78 ++++++\n src/libcamera/v4l2_controls.cpp | 337 ++++++++++++++++++++++++++\n src/libcamera/v4l2_device.cpp | 219 +++++++++++++++++\n 8 files changed, 808 insertions(+), 1 deletion(-)\n create mode 100644 src/libcamera/include/v4l2_controls.h\n create mode 100644 src/libcamera/v4l2_controls.cpp\n\n--\n2.21.0"}