{"id":13978,"url":"https://patchwork.libcamera.org/api/1.1/covers/13978/?format=json","web_url":"https://patchwork.libcamera.org/cover/13978/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210929133030.401961-1-umang.jain@ideasonboard.com>","date":"2021-09-29T13:30:26","name":"[libcamera-devel,v4,0/4] Camera3RequestDescriptors std::map => std::queue","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/13978/mbox/","series":[{"id":2586,"url":"https://patchwork.libcamera.org/api/1.1/series/2586/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2586","date":"2021-09-29T13:30:26","name":"Camera3RequestDescriptors std::map => std::queue","version":4,"mbox":"https://patchwork.libcamera.org/series/2586/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/13978/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BDC5AC3243\n\tfor ;\n\tWed, 29 Sep 2021 13:30:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1F4B2691AA;\n\tWed, 29 Sep 2021 15:30:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B336269185\n\tfor ;\n\tWed, 29 Sep 2021 15:30:38 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.251.226.9])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A3D2F3F0;\n\tWed, 29 Sep 2021 15:30:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qghG+fE3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1632922238;\n\tbh=e1K/z4HQYKEucq4lczmeeuBcQMMe7DM2Y9tAB7QhvVw=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=qghG+fE3mWjlGryHrmCcWWIYk2glxnym4DBYNZjUzWVBEEZTF63V5CKitvlyXeDG0\n\tHeNjCajQnPCcolT1lOeHzn9KDGX8hpw+yoVOk9j6HtlcwL0GfhA30OsHPsxfn0EQL7\n\tMBE/iABwvHSzGftIgIx7S/zDPFmHjDroLeTOgjqc=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 29 Sep 2021 19:00:26 +0530","Message-Id":"<20210929133030.401961-1-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 0/4] Camera3RequestDescriptors std::map\n\t=> std::queue","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"As per the extended design discussion for libcamera HAL, this series\naddresses the part I of the design that will lead to new iterations\nfor async post-processor eventually.\n\nThe series mainly ports storage of Camera3RequestDescriptor from\nstd::map => queue while fixing out-of-order request completion from\nabortRequest(). The series also accounts for a singular location to\nsend back capture results to the framework (find sendCaptureResults()).\n\nThe series has been validated on CTS: 230 / 231\n(carrying [PATCH v3 0/1] android: Wait on acquisition fences in\nCameraStream)\n\nChanges in v4:\n- New patch 3/4, makes abortRequest() and notifyError() as const\n- Pop descriptor even on Fatal logging\n- Fix a missing mutex lock\n- spacing around sendCaptureResults() \n- add a \\todo on measuring perf impact on grain-vs-coarse locking\n\nChanges in v3:\n- Change abortRequest to accept a descriptor only, in 3/3\n- Fix wrong logic around abortRequest() descriptor selection\n - Last request descriptor was selected instead of current one\n- Use of `auto` whereever applicable\n- simplify descriptors_ clearance on stop()\n\nChanges in v2:\n- Use queue instead of deque\n- Fix a race between abortRequest() and queuing a descriptor in 2/3\n- address general comments in v1 review.\n\n\nUmang Jain (4):\n android: camera_worker: Use Camera3RequestDescriptor as cookie\n android: camera_device: Transform descriptors_ map to queue\n android: camera_device: Mark abortRequest() and notifyError() as const\n android: camera_device: Send capture results by inspecting the queue\n\n src/android/camera_device.cpp | 149 +++++++++++++++++++++-------------\n src/android/camera_device.h | 19 ++++-\n src/android/camera_worker.cpp | 4 +-\n src/android/camera_worker.h | 3 +-\n 4 files changed, 111 insertions(+), 64 deletions(-)"}