{"id":13956,"url":"https://patchwork.libcamera.org/api/1.1/covers/13956/?format=json","web_url":"https://patchwork.libcamera.org/cover/13956/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210927213700.25365-1-jacopo@jmondi.org>","date":"2021-09-27T21:36:58","name":"[libcamera-devel,v2,0/2] android: Wait on acquisition fences in CameraStream","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/cover/13956/mbox/","series":[{"id":2577,"url":"https://patchwork.libcamera.org/api/1.1/series/2577/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2577","date":"2021-09-27T21:36:58","name":"android: Wait on acquisition fences in CameraStream","version":2,"mbox":"https://patchwork.libcamera.org/series/2577/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/13956/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A891FBDC71\n\tfor ;\n\tMon, 27 Sep 2021 21:36:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 115306918E;\n\tMon, 27 Sep 2021 23:36:18 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F2D96012C\n\tfor ;\n\tMon, 27 Sep 2021 23:36:16 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 150B2C0002;\n\tMon, 27 Sep 2021 21:36:15 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 27 Sep 2021 23:36:58 +0200","Message-Id":"<20210927213700.25365-1-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.32.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 0/2] android: Wait on acquisition\n\tfences in CameraStream","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"An acquisition fence is associated to each camera3_stream_buffer_t part of a\ncapture request.\n\nStreams generated by libcamera (Type::Direct) are queued to the\nlibcamera::Camera and their fences are waited on by the CameraWorker class.\n\nAcquisition fences for Streams generated by post-processing have been so far\nignored and the fence was not closed, resulting in a leak that crashed the\ncamera service with:\n\n FATAL FileDescriptor file_descriptor.cpp:265 Failed to dup() fd: Too many open files\n\nFix this by instrumenting CameraStream to handle fences in the process()\nfunction.\n\nThis is a temporary workaround until libcamera is not instrumented with a\nmechanism to handle fences internally.\n\nv2:\n- Handle ::Internal stream type and shuffle the patch order as suggested by\n Hiro.\n\nJacopo Mondi (2):\n android: Post-pone fences reset in capture result\n android: Wait on fences in CameraStream::process()\n\n src/android/camera_device.cpp | 50 ++++++++++++++++++++++++-----------\n src/android/camera_stream.cpp | 48 +++++++++++++++++++++++++++++++--\n src/android/camera_stream.h | 4 ++-\n 3 files changed, 84 insertions(+), 18 deletions(-)\n\n--\n2.32.0"}