{"id":13849,"url":"https://patchwork.libcamera.org/api/1.1/covers/13849/?format=json","web_url":"https://patchwork.libcamera.org/cover/13849/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210914163709.85751-1-jeanmichel.hautbois@ideasonboard.com>","date":"2021-09-14T16:37:04","name":"[libcamera-devel,v8,0/5] Move and improve AWB structures","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/13849/mbox/","series":[{"id":2531,"url":"https://patchwork.libcamera.org/api/1.1/series/2531/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2531","date":"2021-09-14T16:37:04","name":"Move and improve AWB structures","version":8,"mbox":"https://patchwork.libcamera.org/series/2531/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/13849/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4CF55BDC71\n\tfor ;\n\tTue, 14 Sep 2021 16:37:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7DBC56918B;\n\tTue, 14 Sep 2021 18:37:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 832F660132\n\tfor ;\n\tTue, 14 Sep 2021 18:37:13 +0200 (CEST)","from tatooine.ideasonboard.com (unknown\n\t[IPv6:2a01:e0a:169:7140:d0a7:2575:a724:b30a])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 17A5F2A5;\n\tTue, 14 Sep 2021 18:37:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"u2lljLsB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1631637433;\n\tbh=PKkc5tbouGBKawHkruyD2ow82Lt93FAA79z4yv2k7R0=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=u2lljLsBoku8dUvBCwiw4270opp413askQKDKlftONryVA9PMu+uvR8DlLNh0aj9h\n\tHzlMTAj9fZpe/FRD5Vp+oxMlemoxTdwDTDaKkFOw5qGn7l59vA290u/blxPuOJwp7j\n\t+G1rJgU5Mx2j2EX6a3YHeJVI4smIutuvksWzidE0=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 14 Sep 2021 18:37:04 +0200","Message-Id":"<20210914163709.85751-1-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.30.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v8 0/5] Move and improve AWB structures","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"On the path towards a cleaner and more documented IPA for the IPU3, this\nseries changes the structures used by the AWB algorithm.\n\n- v8 inverts patch 4 and 5 from the previous series, and the final one\n is now the moving of the new stats structure. And the one before is a\n rework to make the namings consistent between all algorithms (which\n leads to a bit more code reworded in AGC).\n- v7 changes a bit of naming in the Awb::generateAwbStats function to\n make it even clearer.\n- v6 adds a real better documentation in the AWB part (thanks Kieran)\n and properly defines the terms used in the algorithm (cell and zone).\n A new patch appears which is here to make it consistent.\n- v5 is a small rewording of the commit messages for 2/4 and 4/4.\n- v4 changes the way the structure is used in intel-ipu3.h to avoid any\n change in the buffer size. It should be transparent.\n\nPatch 1/5 moves the AWB structures to be able to use those from the\nipa::ipu3::algorithms namespace (by AGC at least).\n\nPatch 2/5 renames the stats region structure to make it clear it is an\naccumulator structure.\n\nPatch 3/5 is improving the Accumulator structure to have the same layout\nas the IPAFrameContext::awb structure.\n\nPatch 4/5 is a bit reworked and covers Awb and Agc. Awb is only\nrenaming, while Agc should have been only that... if it was not badly\nwritten :-). So it has been reworked a bit more.\n\nPatch 5/5 is removing the IPU3AwbCell from libcamera, and uses its\ndefinition directly from the kernel header.\n\nJean-Michel Hautbois (5):\n ipa: ipu3: Move the AWB stats structures\n ipa: ipu3: Rename IspStatsRegion to Accumulator\n ipa: ipu3: Change Accumulator structure layout\n ipa: ipu3: Make the naming consistent\n ipa: ipu3: Replace ipa::ipu3::algorithms::Ipu3AwbCell\n\n include/linux/intel-ipu3.h | 28 +++++++-\n src/ipa/ipu3/algorithms/agc.cpp | 43 +++---------\n src/ipa/ipu3/algorithms/awb.cpp | 120 +++++++++++++++++++++-----------\n src/ipa/ipu3/algorithms/awb.h | 30 +++-----\n 4 files changed, 128 insertions(+), 93 deletions(-)"}