{"id":13698,"url":"https://patchwork.libcamera.org/api/1.1/covers/13698/?format=json","web_url":"https://patchwork.libcamera.org/cover/13698/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210906230436.17106-1-laurent.pinchart@ideasonboard.com>","date":"2021-09-06T23:04:31","name":"[libcamera-devel,v1,0/5] qcam: Fix stride handling","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/13698/mbox/","series":[{"id":2483,"url":"https://patchwork.libcamera.org/api/1.1/series/2483/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2483","date":"2021-09-06T23:04:32","name":"qcam: Fix stride handling","version":1,"mbox":"https://patchwork.libcamera.org/series/2483/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/13698/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 25191BDC71\n\tfor ;\n\tMon, 6 Sep 2021 23:05:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 738C56917A;\n\tTue, 7 Sep 2021 01:05:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 36BBA60253\n\tfor ;\n\tTue, 7 Sep 2021 01:04:58 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AB3AE891\n\tfor ;\n\tTue, 7 Sep 2021 01:04:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CCC5Cwf7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630969497;\n\tbh=bK/Rq2Ciw/nMNkJWvIjBjUeaPnplvMWktId3j2IDuQQ=;\n\th=From:To:Subject:Date:From;\n\tb=CCC5Cwf7+FXekHj1QtuKmVQl+UpbsT3xNYYFA87B5fszYTxAaKDse45wEpWh2OrPe\n\tinZ0OTMvUQbl+5OJfQSJofmswS8MoPLokh8fc9Aht8+hOjoClmw3jh3wHZL+YlwQCX\n\tWt+qhhK2Bf0scvSnZka6fEh+6vyRS0A9cQwmEOLE=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 7 Sep 2021 02:04:31 +0300","Message-Id":"<20210906230436.17106-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v1 0/5] qcam: Fix stride handling","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello,\n\nI came to realize that stride support was broken in qcam when testing\n[1] on Raspberry Pi with the YUV420 format. This patch series fixes it\nfor all RGB and YUV formats, and also adds YUV420 support to the\nsoftware converter.\n\nThe patches apply on top of [1]. I've tested ARGB8888, YUYV, NV12 and\nYUV420, with both viewfinders. Only YUV420 had padding at the end of\nlines, so other formats may not work properly when padding is present,\nbut there should at least be no regression.\n\n[1] https://lists.libcamera.org/pipermail/libcamera-devel/2021-September/024477.html\n\nLaurent Pinchart (5):\n qcam: viewfinder: Pass stride value to viewfinder\n qcam: format_converter: Add configurable stride support\n qcam: format_converter: Rename YUV and NV to YUVPacked and\n YUVSemiPlanar\n qcam: format_converter: Add fully-planar YUV formats support\n qcam: viewfinder_gl: Support configurable stride in shaders\n\n src/qcam/assets/shader/identity.vert | 4 +-\n src/qcam/format_converter.cpp | 187 ++++++++++++++++++---------\n src/qcam/format_converter.h | 14 +-\n src/qcam/main_window.cpp | 3 +-\n src/qcam/viewfinder.h | 3 +-\n src/qcam/viewfinder_gl.cpp | 61 ++++++---\n src/qcam/viewfinder_gl.h | 4 +-\n src/qcam/viewfinder_qt.cpp | 4 +-\n src/qcam/viewfinder_qt.h | 3 +-\n 9 files changed, 195 insertions(+), 88 deletions(-)"}