{"id":13630,"url":"https://patchwork.libcamera.org/api/1.1/covers/13630/?format=json","web_url":"https://patchwork.libcamera.org/cover/13630/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210906140152.636883-1-jacopo@jmondi.org>","date":"2021-09-06T14:01:47","name":"[libcamera-devel,0/5] android: Fix descriptors_ clean up","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/cover/13630/mbox/","series":[{"id":2448,"url":"https://patchwork.libcamera.org/api/1.1/series/2448/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2448","date":"2021-09-06T14:01:47","name":"android: Fix descriptors_ clean up","version":1,"mbox":"https://patchwork.libcamera.org/series/2448/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/13630/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B139EBDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon,  6 Sep 2021 14:01:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6C5B66916A;\n\tMon,  6 Sep 2021 16:01:09 +0200 (CEST)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D424060137\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  6 Sep 2021 16:01:07 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 741914001D;\n\tMon,  6 Sep 2021 14:01:07 +0000 (UTC)"],"From":"Jacopo Mondi <jacopo@jmondi.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Mon,  6 Sep 2021 16:01:47 +0200","Message-Id":"<20210906140152.636883-1-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.32.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 0/5] android: Fix descriptors_ clean up","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"While testing Hiro's patch, which I'm re-sending here, I tried as well to\ncentralize the streams_ and descriptors_ cleanup.\n\nThis lead to the discovery of a potentially missed frame error in CameraWorker.\n\nOn top of that, I have added two assertions to enforce the correct Camera\nbehavior after a stop() call.\n\nThanks\n   j\n\nHirokazu Honda (1):\n  android: camera_device: Fix crash in calling CameraDevice::close()\n\nJacopo Mondi (4):\n  android: camera_device: Clear streams_ in stop()\n  android: camera_device: Make abortRequest() take a const\n  android: camera_worker: Notify fence wait failures\n  android: camera_device: Assert descriptors_ is empty\n\n src/android/camera_device.cpp | 54 ++++++++++++++++++++++++++---------\n src/android/camera_device.h   |  3 +-\n src/android/camera_worker.cpp | 10 ++++---\n src/android/camera_worker.h   |  9 ++++--\n 4 files changed, 55 insertions(+), 21 deletions(-)\n\n--\n2.32.0"}