{"id":13617,"url":"https://patchwork.libcamera.org/api/1.1/covers/13617/?format=json","web_url":"https://patchwork.libcamera.org/cover/13617/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210906020100.14430-1-laurent.pinchart@ideasonboard.com>","date":"2021-09-06T02:00:33","name":"[libcamera-devel,v2,00/27] libcamera: Handle fallout of FrameBuffer offset support","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/13617/mbox/","series":[{"id":2446,"url":"https://patchwork.libcamera.org/api/1.1/series/2446/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2446","date":"2021-09-06T02:00:33","name":"libcamera: Handle fallout of FrameBuffer offset support","version":2,"mbox":"https://patchwork.libcamera.org/series/2446/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/13617/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2E156BDC71\n\tfor ;\n\tMon, 6 Sep 2021 02:01:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9067E69172;\n\tMon, 6 Sep 2021 04:01:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5314360254\n\tfor ;\n\tMon, 6 Sep 2021 04:01:21 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BF6A9317;\n\tMon, 6 Sep 2021 04:01:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"inZJLOoD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1630893681;\n\tbh=65iKuOlSBYPXqNSr00BifbF0pPFRtQPTb6yedjcKT0Y=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=inZJLOoDm5ZJ79POQ1Z8Q62g32/6OsPID51Qn6aZ2olFPA+UUGdtTzbti7o2/cUCV\n\tvmi7PHE7za2YCEk36ni7GHbZ+4JLXlmGqJz+AmBgdmhUSAQ4LKKd2Ea66g7+9s+OSW\n\tzsfwsowtpgDdC16ykht4JDnCIEUSEgnnDwk93Clg=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 6 Sep 2021 05:00:33 +0300","Message-Id":"<20210906020100.14430-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 00/27] libcamera: Handle fallout of\n\tFrameBuffer offset support","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello everybody,\n\nThis patch series started as an investigation of a qcam failure with\nIPU3 after the merge of the FrameBuffer offset support. While a hack in\nqcam would be possible, I decided to instead address the core issue and\nfix it in V4L2VideoDevice.\n\nCompared to v1, the series now includes fixes for cam and qcam in\naddition to the changes needed in the libcamera core. They have been\ntested with the Raspberry Pi, IPU3, VIMC and UVC pipeline handlers.\n\nThe GStreamer element seems to work fine without any change required.\nThe V4L2 compatibility layer is still broken, and I haven't tested the\nAndroid HAL yet (any volunteer ?).\n\nThe most important change is in patches 13/27 and 14/27, which translate\nbetween V4L2 buffers and libcamera FrameBuffer to handle the case where\na multi-planar frame buffer is used with the V4L2 single-planar API.\nIt's working more or less by chance at the moment (except in qcam where\nit's broken, and possibly in other places I haven't tested). Patches\n01/27 to 12/27 are cleanups and additions to prepare for the work in\nV4L2VideoDevice, and patch 15/27 is a small cleanup on top. Patches\n16/27 and 17/27 then improve the FrameBuffer class API as a cleanup.\n\nPatches 18/27 to 27/27 fix the cam and qcam applications, as well as an\nissue in the Android HAL. Worth being noted is patch 19/27 that\nintroduces an Image class shared by cam and qcam. The class duplicates\nthe MappedFrameBuffer implementation private to libcamera. I've tried to\nrework MappedFrameBuffer into something I would be happy to see in the\npublic API, but failed to do so in a reasonable amount of time, and I\ndidn't want to delay this important regression fix.\n\nThis series doesn't break any unit test, as vimc doesn't support NV12.\nAddition of NV12 support to the vimc kernel driver would be very nice,\nin order to test multi-planar support in our unit tests. Volunteers are\nwelcome ;-)\n\nLaurent Pinchart (27):\n libcamera: base: utils: Use size_t for index in utils::enumerate()\n libcamera: file_descriptor: Add a function to retrieve the inode\n libcamera: v4l2_videodevice: Drop toV4L2PixelFormat()\n libcamera: Use V4L2PixelFormat::fromPixelFormat()\n libcamera: formats: Move plane info structure to PixelFormatInfo\n libcamera: formats: Add planeSize() helpers to PixelFormatInfo\n libcamera: formats: Support V4L2 non-contiguous formats\n libcamera: framebuffer: Move planes check to constructor\n libcamera: framebuffer: Add a function to check if planes are\n contiguous\n libcamera: v4l2_videodevice: Cache PixelFormatInfo\n libcamera: v4l2_videodevice: Document plane handling in createBuffer()\n libcamera: v4l2_videodevice: Take stride into account to compute\n offsets\n libcamera: v4l2_videodevice: Coalesce planes when queuing buffer\n libcamera: v4l2_videodevice: Split planes when dequeuing buffer\n libcamera: v4l2_videodevice: Use utils::enumerate()\n libcamera: framebuffer: Allocate metadata planes at construction time\n libcamera: framebuffer: Prevent modifying the number of metadata\n planes\n android: camera_device: Don't assume all planes use the same fd\n cam: Add Image class\n cam: file_sink: Use Image class to access pixel data\n cam: drm: Support per-plane stride values\n cam: drm: Set per-plane offsets when creating DRM frame buffer\n cam: drm: Avoid importing the same dmabuf multiple times\n qcam: Print bytesused for all planes\n qcam: Use Image class to access pixel data\n qcam: viewfinder_gl: Support multi-planar buffers\n qcam: viewfinder_qt: Support multi-planar buffers\n\n include/libcamera/base/utils.h | 4 +-\n include/libcamera/file_descriptor.h | 3 +\n include/libcamera/framebuffer.h | 19 +-\n include/libcamera/internal/formats.h | 22 +-\n include/libcamera/internal/framebuffer.h | 2 +\n include/libcamera/internal/v4l2_pixelformat.h | 2 +-\n include/libcamera/internal/v4l2_videodevice.h | 3 +-\n src/android/camera_device.cpp | 25 +-\n src/android/mm/generic_camera_buffer.cpp | 11 +-\n src/android/yuv/post_processor_yuv.cpp | 10 +-\n src/cam/camera_session.cpp | 4 +-\n src/cam/drm.cpp | 38 +-\n src/cam/drm.h | 7 +-\n src/cam/file_sink.cpp | 44 +--\n src/cam/file_sink.h | 6 +-\n src/cam/image.cpp | 107 +++++\n src/cam/image.h | 52 +++\n src/cam/kms_sink.cpp | 28 +-\n src/cam/meson.build | 1 +\n src/libcamera/file_descriptor.cpp | 26 ++\n src/libcamera/formats.cpp | 373 ++++++++++++++----\n src/libcamera/framebuffer.cpp | 57 ++-\n src/libcamera/pipeline/ipu3/cio2.cpp | 4 +-\n src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-\n .../pipeline/raspberrypi/raspberrypi.cpp | 8 +-\n src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 6 +-\n src/libcamera/pipeline/simple/converter.cpp | 8 +-\n src/libcamera/pipeline/simple/simple.cpp | 4 +-\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 6 +-\n src/libcamera/pipeline/vimc/vimc.cpp | 8 +-\n src/libcamera/v4l2_pixelformat.cpp | 11 +-\n src/libcamera/v4l2_videodevice.cpp | 196 ++++++---\n src/qcam/format_converter.cpp | 18 +-\n src/qcam/format_converter.h | 9 +-\n src/qcam/main_window.cpp | 38 +-\n src/qcam/main_window.h | 4 +-\n src/qcam/meson.build | 1 +\n src/qcam/viewfinder.h | 6 +-\n src/qcam/viewfinder_gl.cpp | 45 +--\n src/qcam/viewfinder_gl.h | 4 +-\n src/qcam/viewfinder_qt.cpp | 20 +-\n src/qcam/viewfinder_qt.h | 2 +-\n src/v4l2/v4l2_camera_proxy.cpp | 11 +-\n test/libtest/buffer_source.cpp | 3 +-\n test/utils.cpp | 10 +-\n 45 files changed, 911 insertions(+), 357 deletions(-)\n create mode 100644 src/cam/image.cpp\n create mode 100644 src/cam/image.h"}