{"id":13571,"url":"https://patchwork.libcamera.org/api/1.1/covers/13571/?format=json","web_url":"https://patchwork.libcamera.org/cover/13571/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210831063438.785767-1-hiroh@chromium.org>","date":"2021-08-31T06:34:33","name":"[libcamera-devel,0/5] Improve/Clean up post processors code in android","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/1.1/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"mbox":"https://patchwork.libcamera.org/cover/13571/mbox/","series":[{"id":2423,"url":"https://patchwork.libcamera.org/api/1.1/series/2423/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2423","date":"2021-08-31T06:34:33","name":"Improve/Clean up post processors code in android","version":1,"mbox":"https://patchwork.libcamera.org/series/2423/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/13571/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2D46DBD87D\n\tfor ;\n\tTue, 31 Aug 2021 06:35:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6DB1F6916B;\n\tTue, 31 Aug 2021 08:35:06 +0200 (CEST)","from mail-pf1-x429.google.com (mail-pf1-x429.google.com\n\t[IPv6:2607:f8b0:4864:20::429])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8474B60137\n\tfor ;\n\tTue, 31 Aug 2021 08:35:04 +0200 (CEST)","by mail-pf1-x429.google.com with SMTP id g14so14180562pfm.1\n\tfor ;\n\tMon, 30 Aug 2021 23:35:04 -0700 (PDT)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:3c62:aba4:18ea:5441])\n\tby smtp.gmail.com with ESMTPSA id\n\td17sm16304027pfn.110.2021.08.30.23.35.00\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 30 Aug 2021 23:35:02 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"UtuWWnSK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=h8Tw1IXyOejNW5+a5zeSHefyLqWZKFSxeu/m6pUvL4E=;\n\tb=UtuWWnSK6/mm5prZkg/TXUUC+7jbSRnLcr7gQYJ5FKxzQnZNNPk6F5dYW/ptVLZZP6\n\tS2dwuJ1z2rJfcP+F3VCExe/veC9iFyZSQNiSjCeUzHtMARxklun2KOBrNTviE11SyjZw\n\teBGD+9tKmXPrS3eMZNYHipUOgpbYBHXkTJ93s=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=h8Tw1IXyOejNW5+a5zeSHefyLqWZKFSxeu/m6pUvL4E=;\n\tb=UY+IE7M5j8Q9lDBvwRGbUF2wJa9uPL7fog/O2Tz8b8gC+vcoYpwbhybDdJG7eX4PQP\n\tCsHXeKcjYytk60JEcum1sa7KOeXF03Pu3Bh4/O3MWr3nfoVxM4Wc+rW0l2y6cj7EBqHU\n\tj3LTye2Yk4+fQkJafcoA27Vq/NsB/ZS4lpciTDWITfSqgnut2+SiywezA8Gl+7zyJwQV\n\taUFeidr88iIfK4cEzFZx1lEFzw3dZB8LffTbtbQGWBFPSDYIKX1sFp9ZhjckJn/S36zs\n\thgoE9uJCjkdahzNJSye+AQ7U7OZ4X4PlW5tAPcfUXy5eJtOf6+hoETB4JzbFia1lQ+ZL\n\tqagg==","X-Gm-Message-State":"AOAM531BLEXJthYagtg3NooqIvA/X2DzxvGoCIxJIGmbw7k1LWAKA1rt\n\tEelTW/80OqL3aVMSiDbgyFiAvFRldAXpQA==","X-Google-Smtp-Source":"ABdhPJwXNtp/J8HP1IsTnBjZPuUKbY8bpmds3YUViolkEO+pojJWGQTFqRpBAkJ8m6KwCZiXhjsjng==","X-Received":"by 2002:aa7:989d:0:b0:3ef:5f81:5c2f with SMTP id\n\tr29-20020aa7989d000000b003ef5f815c2fmr26835186pfl.44.1630391702692; \n\tMon, 30 Aug 2021 23:35:02 -0700 (PDT)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 31 Aug 2021 15:34:33 +0900","Message-Id":"<20210831063438.785767-1-hiroh@chromium.org>","X-Mailer":"git-send-email 2.33.0.259.gc128427fd7-goog","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 0/5] Improve/Clean up post processors code\n\tin android","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This patch series basically improves and clean ups by some variable\ntypes with MappedBuffer. I also introduce a new MappedBuffer class for\nplanes that are originated in heap i.e. std::vector.\n\nAlthough this is not done in the patch, ideally we should remove all\nthe stride computation in the post processor code. Even though the\nplane address is acquired by MappedBuffer::planes(), the post\nprocessing is done with the manual stride computation. It might be\ndifferent from the actual stride of the plane.\nI think MappedBuffer should provide strides() like CameraBuffer.\n\nHirokazu Honda (5):\n android: yuv: Use CameraBuffer::stride() in PostProcessorYuv\n android: jpeg: thumbnailer: Use MappedFrameBuffer::planes()\n mapped_framebuffer: Introduce MappedVectorBuffer\n thumbnailer: Change the type of thumbnail to MappedBuffer\n android: encoder_libjpeg: Use MappedBuffer for the source frame\n\n .../libcamera/internal/mapped_framebuffer.h | 9 ++++++\n src/android/jpeg/encoder_libjpeg.cpp | 28 +++++++++++--------\n src/android/jpeg/encoder_libjpeg.h | 7 +++--\n src/android/jpeg/post_processor_jpeg.cpp | 14 ++++++----\n src/android/jpeg/thumbnailer.cpp | 14 ++++++----\n src/android/jpeg/thumbnailer.h | 6 +++-\n src/android/yuv/post_processor_yuv.cpp | 13 +++++----\n src/android/yuv/post_processor_yuv.h | 1 -\n src/libcamera/mapped_framebuffer.cpp | 17 +++++++++++\n 9 files changed, 75 insertions(+), 34 deletions(-)\n\n--\n2.33.0.259.gc128427fd7-goog"}