{"id":13382,"url":"https://patchwork.libcamera.org/api/1.1/covers/13382/?format=json","web_url":"https://patchwork.libcamera.org/cover/13382/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210818083842.31778-1-umang.jain@ideasonboard.com>","date":"2021-08-18T08:38:40","name":"[libcamera-devel,0/2] IPC: Avoid memcpy() call with nullptr","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/1.1/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/13382/mbox/","series":[{"id":2368,"url":"https://patchwork.libcamera.org/api/1.1/series/2368/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2368","date":"2021-08-18T08:38:40","name":"IPC: Avoid memcpy() call with nullptr","version":1,"mbox":"https://patchwork.libcamera.org/series/2368/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/13382/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 11848BD87D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 18 Aug 2021 08:38:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5F1E468895;\n\tWed, 18 Aug 2021 10:38:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 20DEA6025E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 18 Aug 2021 10:38:55 +0200 (CEST)","from perceval.ideasonboard.com (unknown [103.238.109.15])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B379F466;\n\tWed, 18 Aug 2021 10:38:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"g02J2l06\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1629275934;\n\tbh=jU7hL3uvkFcHOiuVROuYjoOdEs6bNPTF8vQwVyIPRlk=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=g02J2l06e1Q/lZ0+pcCQPBzhWf6sSMv2mNZg/FBBsHNiAYWY4kDYri9yrwfOEOAvu\n\ts3AMc/UdahHf1Q8CIQ9dvSBwszkRq8v0sjPEURRoDasliiK701mTsv94+HnNdcawAS\n\tZ54W+qH921MGG6BmmQQUYGC10GMYTc50AoXjj7oY=","From":"Umang Jain <umang.jain@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 18 Aug 2021 14:08:40 +0530","Message-Id":"<20210818083842.31778-1-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 0/2] IPC: Avoid memcpy() call with nullptr","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"During the fd-leak test, compiled with  -Db_sanitize=address,undefined\nI noticed that few runtime errors were logged. The error were non-fatal\nbut were highlighting a underlying problem where memcpy() could been\ncalled with nullptr.\n\nThe commit messages are a brain dump of my understand but probably\nwould have some scope of improvements.\n\nUmang Jain (2):\n  libcamera: ipc_unixsocket: Do not run memcpy with null arguments\n  libcamera: ipc_pipe: Do not run memcpy with null arguments\n\n src/libcamera/ipc_pipe.cpp       | 7 +++++--\n src/libcamera/ipc_unixsocket.cpp | 6 ++++--\n 2 files changed, 9 insertions(+), 4 deletions(-)"}