{"id":13358,"url":"https://patchwork.libcamera.org/api/1.1/covers/13358/?format=json","web_url":"https://patchwork.libcamera.org/cover/13358/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210816043138.957984-1-hiroh@chromium.org>","date":"2021-08-16T04:31:28","name":"[libcamera-devel,RFC,00/10] Add offset to FrameBuffer::Plane","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/1.1/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"mbox":"https://patchwork.libcamera.org/cover/13358/mbox/","series":[{"id":2359,"url":"https://patchwork.libcamera.org/api/1.1/series/2359/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2359","date":"2021-08-16T04:31:28","name":"Add offset to FrameBuffer::Plane","version":1,"mbox":"https://patchwork.libcamera.org/series/2359/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/13358/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8997CBD87D\n\tfor ;\n\tMon, 16 Aug 2021 04:31:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB7D268891;\n\tMon, 16 Aug 2021 06:31:48 +0200 (CEST)","from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com\n\t[IPv6:2607:f8b0:4864:20::1031])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D2B8E6025C\n\tfor ;\n\tMon, 16 Aug 2021 06:31:46 +0200 (CEST)","by mail-pj1-x1031.google.com with SMTP id bo18so24631440pjb.0\n\tfor ;\n\tSun, 15 Aug 2021 21:31:46 -0700 (PDT)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:6f5f:1479:a6ab:4229])\n\tby smtp.gmail.com with ESMTPSA id\n\tu10sm2767417pgj.48.2021.08.15.21.31.42\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 15 Aug 2021 21:31:44 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"FIPF8zPL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=+OyQKYmyBOIO/1bAo2PIwgas8EED1Gw/Bk4kvTqECCw=;\n\tb=FIPF8zPLpCkAyBPgvZHq+qNYWMVMMd6WVtANAONCfonlmBcL9i3Y7w8O3MBr72gof3\n\tUDz19sX1FUMnOoBpVtU/oPuqvbX64eEY76hmnSiWem/v29VlN1iOtPx5lqEd4V6Txdfl\n\tL2yKjwKs6t751Yn633fmdeRRh36JfwiT0v19M=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=+OyQKYmyBOIO/1bAo2PIwgas8EED1Gw/Bk4kvTqECCw=;\n\tb=E/jlx+2jQGrE22R3v+STrvZQ9hR3UuXVGjiuGVjTRZd7PK3/XdBheIRWr46CGl1OtE\n\tXO6Hq5Ry9wIry4X9yOiZJCW221O7X4zjxFh7cOCVrAWvHfvY6o6TtHDL/WPhLIfi/ODy\n\ttyAYp8zH72Jik3bFYLN/qFOo1gqRjinowWJCmQfmuNPE3YWTFJkpLTCBKQEzre52LQcC\n\t/EAt0Y6TFAfJmSNzylR4BW641caDrtj9pqIjHT/oNHUi8lhrTuKzHejgHGmI+aF4EUus\n\t0XDNT1kvLAmHr7wLzfZH9j1sPYigXhTeH53yvANbEq+qeRIePllGYF9pXV1mpKiD+6PV\n\tqfUQ==","X-Gm-Message-State":"AOAM530gUf/G6iQGB2FGKMCHISmcHMluJw4Q6I/DzZTySD4JPN0U11fL\n\tBQsKPGIkm5wGzLSaqsj6Xqekhhz98PeaJg==","X-Google-Smtp-Source":"ABdhPJz/cgWbF77ZzbDf3yVMfkN3q3oZazD8SBuRfIAEjfZK07kSN93BxMx6snIw87qZYI8xXTmQMw==","X-Received":"by 2002:a17:90b:1950:: with SMTP id\n\tnk16mr15164726pjb.11.1629088304711; \n\tSun, 15 Aug 2021 21:31:44 -0700 (PDT)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 16 Aug 2021 13:31:28 +0900","Message-Id":"<20210816043138.957984-1-hiroh@chromium.org>","X-Mailer":"git-send-email 2.33.0.rc1.237.g0d66db33f3-goog","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH 00/10] Add offset to FrameBuffer::Plane","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Since FrameBuffer::Plane doesn't have an offset variable, it is\nimpossible to map the FrameBuffer::Plane correctly. This series fixes\nthe issue by adding an offset and alignes some code of mapping and\ncreating FrameBuffer::Plane with the new offset.\n\nI probably miss some code of using FrameBuffer::Plane. To detect the\nbug, I add the assertion to FrameBuffer.\n\nHirokazu Honda (10):\n libcamera: framebuffer: Add offset to FrameBuffer::Plane\n libcamera: ipa_data_serializer: Modify (de)serialization for offset\n libcamera: mapped_framebuffer: Return plane begin address by\n MappedBuffer::maps()\n cam: file_sink: Use offset in mapping FrameBuffer\n ipa: rkisp1: Use offset in mapping IPABuffer\n qcam: main_window: Use offset mapping FrameBuffer\n gstreamer: gstlibcameraallocator: Use offset in creating a buffer\n libcamera: v4l2_videodevice: Create color-format planes in\n CreateBuffer()\n android: camera_device: Fill offset and right length in\n CreateFrameBuffer()\n libcamera: framebuffer: Add assertion to detect offset is unfilled\n\n include/libcamera/framebuffer.h | 12 ++++-\n .../libcamera/internal/mapped_framebuffer.h | 4 +-\n include/libcamera/internal/v4l2_videodevice.h | 4 +-\n src/android/camera_device.cpp | 38 +++++++-------\n src/cam/file_sink.cpp | 5 +-\n src/cam/file_sink.h | 1 +\n src/gstreamer/gstlibcameraallocator.cpp | 3 +-\n src/ipa/rkisp1/rkisp1.cpp | 4 +-\n src/libcamera/framebuffer.cpp | 11 ++--\n src/libcamera/ipa_data_serializer.cpp | 5 +-\n src/libcamera/mapped_framebuffer.cpp | 51 +++++++++++++++----\n src/libcamera/v4l2_videodevice.cpp | 28 +++++++++-\n src/qcam/main_window.cpp | 15 ++++--\n src/qcam/main_window.h | 1 +\n 14 files changed, 136 insertions(+), 46 deletions(-)\n\n--\n2.33.0.rc1.237.g0d66db33f3-goog"}