{"id":12761,"url":"https://patchwork.libcamera.org/api/1.1/covers/12761/?format=json","web_url":"https://patchwork.libcamera.org/cover/12761/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210701230741.14320-1-laurent.pinchart@ideasonboard.com>","date":"2021-07-01T23:07:38","name":"[libcamera-devel,0/3] base: Fix crash with recursive messages dispatch","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/12761/mbox/","series":[{"id":2198,"url":"https://patchwork.libcamera.org/api/1.1/series/2198/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2198","date":"2021-07-01T23:07:38","name":"base: Fix crash with recursive messages dispatch","version":1,"mbox":"https://patchwork.libcamera.org/series/2198/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/12761/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3010AC3222\n\tfor ;\n\tThu, 1 Jul 2021 23:08:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8D1A560288;\n\tFri, 2 Jul 2021 01:08:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A08AA60288\n\tfor ;\n\tFri, 2 Jul 2021 01:08:25 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0FAB54AB;\n\tFri, 2 Jul 2021 01:08:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hNjX1R4X\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1625180905;\n\tbh=OsuaE2Rg+2VPY3rbkU1MhtqFpwCeoTalyer3M66igqU=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=hNjX1R4XaT46IlOVkNOGpQY6n6J+vXHzSWmJBF4xejQQHmQwxNp6nkxv4XvHGvyTM\n\tj/k06Kt5+XSXitRAmh5utOAepX9TsWmq8sZEGIzojIlvgaCfW+bJOJMUG/Axlo7pmt\n\tbKZrEt1nLWy5KDhGG3m+aDAALpfgnqzQ5SJkcXS4=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 2 Jul 2021 02:07:38 +0300","Message-Id":"<20210701230741.14320-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 0/3] base: Fix crash with recursive\n\tmessages dispatch","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello,\n\nThis patch series fixes a crash related to recursive dispatch of\nmessages, as reported in https://bugs.libcamera.org/show_bug.cgi?id=26.\n\nPatch 1/3 is a small drive-by documentation fix. Patch 2/3 adds a test\ncase to trigger the issue, and patch 3/3 fixes it. Please see patch 3/3\nfor a detailed explanation of the problem and the fix.\n\nDavid, would you be able to check if this fixes the issue you've\nreported ?\n\nLaurent Pinchart (3):\n base: thread: Document the postMessage() function as thread-safe\n test: message: Test recursive Thread::dispatchMessages() calls\n base: thread: Fix recursive calls to dispatchMessages()\n\n src/libcamera/base/thread.cpp | 45 ++++++++++++++++++------\n test/message.cpp | 66 +++++++++++++++++++++++++++++++++--\n 2 files changed, 99 insertions(+), 12 deletions(-)"}