{"id":12660,"url":"https://patchwork.libcamera.org/api/1.1/covers/12660/?format=json","web_url":"https://patchwork.libcamera.org/cover/12660/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210619105151.20012-1-jacopo@jmondi.org>","date":"2021-06-19T10:51:50","name":"[libcamera-devel,RFC,0/1] android: Introduce CameraCapabilities","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/cover/12660/mbox/","series":[{"id":2156,"url":"https://patchwork.libcamera.org/api/1.1/series/2156/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2156","date":"2021-06-19T10:51:50","name":"android: Introduce CameraCapabilities","version":1,"mbox":"https://patchwork.libcamera.org/series/2156/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/12660/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7D820BD78E\n\tfor ;\n\tSat, 19 Jun 2021 10:51:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B20E968944;\n\tSat, 19 Jun 2021 12:51:08 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F00968940\n\tfor ;\n\tSat, 19 Jun 2021 12:51:06 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 134DE240004;\n\tSat, 19 Jun 2021 10:51:05 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 19 Jun 2021 12:51:50 +0200","Message-Id":"<20210619105151.20012-1-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.31.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC 0/1] android: Introduce CameraCapabilities","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Yeah, I know \"5 files changed, 1245 insertions(+), 1159 deletions(-)\" sounds\nscary but it's mostly about moving stuff out from camera_device.cpp to a new\ncamera_capabilities.cpp.\n\nWhat I mostly care about are coments on the interface between the 2 classes\n(see the usage of capabilities_ in camera_device.cpp). The code has been moved\nwithout modifications if not small changes to comments here and there, so that\npart should be \"easy\" to review.\n\nI think the new layout is not too bad. Also, controls and dynamic metadata\nhandling could then be moved to a new camera_controls.cpp which can be\ninitialized with the static information produced by CameraCapabilities.\nWhat do you think ?\n\nNo regressions detected by running CTS with libcamera subplan (run 2 times in a\nrow) nor when testing with CCA.\n\nThanks\n j\n\nJacopo Mondi (1):\n android: Introduce CameraCapabilties class\n\n src/android/camera_capabilities.cpp | 1165 +++++++++++++++++++++++++++\n src/android/camera_capabilities.h | 64 ++\n src/android/camera_device.cpp | 1147 +-------------------------\n src/android/camera_device.h | 27 +-\n src/android/meson.build | 1 +\n 5 files changed, 1245 insertions(+), 1159 deletions(-)\n create mode 100644 src/android/camera_capabilities.cpp\n create mode 100644 src/android/camera_capabilities.h\n\n--\n2.31.1"}