{"id":12414,"url":"https://patchwork.libcamera.org/api/1.1/covers/12414/?format=json","web_url":"https://patchwork.libcamera.org/cover/12414/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210526000855.17501-1-laurent.pinchart@ideasonboard.com>","date":"2021-05-26T00:08:53","name":"[libcamera-devel,0/2] Fix Android camera HAL compilation on gcc 7 and 8","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/12414/mbox/","series":[{"id":2067,"url":"https://patchwork.libcamera.org/api/1.1/series/2067/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2067","date":"2021-05-26T00:08:53","name":"Fix Android camera HAL compilation on gcc 7 and 8","version":1,"mbox":"https://patchwork.libcamera.org/series/2067/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/12414/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8588BC3200\n\tfor ;\n\tWed, 26 May 2021 00:09:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9D26068925;\n\tWed, 26 May 2021 02:09:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 05E5E601AA\n\tfor ;\n\tWed, 26 May 2021 02:09:05 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7F0F0332\n\tfor ;\n\tWed, 26 May 2021 02:09:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kVRPWdQH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1621987744;\n\tbh=RcYFFbYQ/nC3eUB902PZgO2rxyaeIEg3XxeLXE6R46Q=;\n\th=From:To:Subject:Date:From;\n\tb=kVRPWdQH9EAoWaWstXuZ2t4CPEXg+wCo+VQtcYmrCMC9+CEhmj0hNb64PzOV7AGmI\n\tRUxaGoaoP+7Olu5/OCG/rBMrEFA7j/SRkWMx3Q+vmdu3Wfhfq4YzdyXwu8osT7G2Rp\n\tUvXZhUXrEh95M5acQpAc5LJHXrE6uKHLLh8sw7qw=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 26 May 2021 03:08:53 +0300","Message-Id":"<20210526000855.17501-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.28.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 0/2] Fix Android camera HAL compilation on\n\tgcc 7 and 8","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello,\n\nThis patch series fixes a compilation breakage of the camera HAL with\ngcc 7 and 8 (technically a link breakage with gcc 8), introduced by\nusage of the file system library.\n\nThe first patch is a small refactoring, the second patch includes the\nreal fix, details are included there.\n\nThe compilation fix is a bit of a hack. If we need to use the file\nsystem library in more places (and I think we will), we should either\ndrop support for gcc 7 completely, or abstract file system operations in\nhelper classes. Any opinion ?\n\nLaurent Pinchart (2):\n android: camera_hal_config: Move include to .cpp file\n android: Fix file system library usage on gcc 7 and 8\n\n meson.build | 8 ++++++++\n src/android/camera_hal_config.cpp | 8 ++++++++\n src/android/camera_hal_config.h | 1 -\n 3 files changed, 16 insertions(+), 1 deletion(-)"}