{"id":12327,"url":"https://patchwork.libcamera.org/api/1.1/covers/12327/?format=json","web_url":"https://patchwork.libcamera.org/cover/12327/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210520151714.3366445-1-naush@raspberrypi.com>","date":"2021-05-20T15:17:10","name":"[libcamera-devel,v2,0/4] Switch RaspberryPi IPA to use std::chrono::duration","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"mbox":"https://patchwork.libcamera.org/cover/12327/mbox/","series":[{"id":2039,"url":"https://patchwork.libcamera.org/api/1.1/series/2039/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2039","date":"2021-05-20T15:17:10","name":"Switch RaspberryPi IPA to use std::chrono::duration","version":2,"mbox":"https://patchwork.libcamera.org/series/2039/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/12327/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A5ECDC31FF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 20 May 2021 15:17:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 00FC46891E;\n\tThu, 20 May 2021 17:17:22 +0200 (CEST)","from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n\t[IPv6:2a00:1450:4864:20::334])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0660C602B2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 20 May 2021 17:17:21 +0200 (CEST)","by mail-wm1-x334.google.com with SMTP id\n\tf6-20020a1c1f060000b0290175ca89f698so5646638wmf.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 20 May 2021 08:17:20 -0700 (PDT)","from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:de31:dc1f:6be5:f58e])\n\tby smtp.gmail.com with ESMTPSA id\n\ta11sm3583885wrr.48.2021.05.20.08.17.18\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 20 May 2021 08:17:19 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"XBFdoRIZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=Vo3BdBxjO5AGE4bHT6k2pb6fd9zMmGW+XHXfCEY0wag=;\n\tb=XBFdoRIZh+mWIA+16a2qgi85ggoxNJyPXbAZZbc9fc0KfCoipS6mAS6GRt6vPkkOgw\n\tm1Pd2ZuLAsWbXUk7GzEsqMjkCsIyAU+97kla1+wXAeXMcIaT3BS/gKfzb9nM2Qo3s77+\n\tnBvQeHZqkJ4JyEWhHoNateMBFBpOaIPtl/EpptP6OIxAeRRUml1YWsrIo4gEGGFMicBr\n\ttizuCU2k1iIQPzBi1J7fJk+uUeSGhO+Vs4NXBqbYAJ5JFRTP7HmWyxh7Kkjwe3cvPIJN\n\tblsFyH5MoMW6REFxejHTkAABzwQ0Vbq+mOxDUG3ra8oL8R+CerZnpY+/oVDp65deaw5M\n\tYxug==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=Vo3BdBxjO5AGE4bHT6k2pb6fd9zMmGW+XHXfCEY0wag=;\n\tb=lPZSI2RZF4y88GisQCoB4Lkzn9U5/g6JNmJpDx0F9vFgvn6mOiagUeZ1KNuloQ1nCB\n\tnTA8TCI96ILzUvjibYPb34IpeT7SFg4KkAoftnwFQKv0X+b5686W8TscrQpC6fY2OpME\n\tzg3DtMJTnb3UAY2Cv9JDTdhIAIkgXQv6avVIQOBJvk/q/85FttiAUNz1maa4dYlqh+it\n\tDlIwJgRNIgpcLLPcDV7LAMHHVMf7MLOT4TcvsC4aG/H+g25PWcDupZetHVugELp9oZx2\n\tYIyawovYsZeCQqOhIg5TCfQ9olGb8Cskg8FXO7TwQOJ5MEFZHN7IG7iE2Ww7ui3i1Ib6\n\tF98Q==","X-Gm-Message-State":"AOAM532jpvZO4hNWlbKVn6IAcTZ/y9zdgYk7z8xr55tO9hoA3xMx5IEo\n\t+N8dLk7MfpFw60y1bLVMgQ6L6IGEg7pwSw==","X-Google-Smtp-Source":"ABdhPJzxKSVBFSIcCUSZK8kzpY3rpDFT3Zq9uGemmuqYduaeqCYUpnvP5JpVTrTU4d1Fg9IC0PjzHA==","X-Received":"by 2002:a05:600c:35c3:: with SMTP id\n\tr3mr4059035wmq.63.1621523839950; \n\tThu, 20 May 2021 08:17:19 -0700 (PDT)","From":"Naushir Patuck <naush@raspberrypi.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 20 May 2021 16:17:10 +0100","Message-Id":"<20210520151714.3366445-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 0/4] Switch RaspberryPi IPA to use\n\tstd::chrono::duration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Hi,\n\nHere is version 2 of the std::chrono::duration conversion patch.\n\nChanges since v1:\n\n- Added a helper Duration class in utils.h that provide the functionality needed\nfrom std::chrono::duration.  I have named this class libcamera::utils::Duration.\nHowever, there is an existing libcamera::utils::duration typedef which seems a\nbit close for comfort.  I cannot think of a more suitable name (IpaDuration?),\nso any suggestions would be helpful.\n\n- Fixed all the minors pointed out by David's review.  David, I have removed\nyour tags for 1/4 and 4/4 since the changes from v1 are not entirely trivial.\n\nRegards,\nNaush\n\nNaushir Patuck (4):\n  libcamera: utils: Add helper class for std::chrono::duration\n  ipa: raspberrypi: Switch ipa and cam_helper to use utils::Duration\n  ipa: raspberrypi: Switch AgcAlgorithm API to use utils::Duration\n  ipa: raspberrypi: Switch the AGC/Lux code to use utils::Duration\n\n include/libcamera/internal/utils.h            | 42 +++++++++\n src/ipa/raspberrypi/cam_helper.cpp            | 17 ++--\n src/ipa/raspberrypi/cam_helper.hpp            | 12 ++-\n .../raspberrypi/controller/agc_algorithm.hpp  |  9 +-\n src/ipa/raspberrypi/controller/agc_status.h   | 14 +--\n src/ipa/raspberrypi/controller/camera_mode.h  |  6 +-\n .../raspberrypi/controller/device_status.h    |  6 +-\n src/ipa/raspberrypi/controller/rpi/agc.cpp    | 88 +++++++++++--------\n src/ipa/raspberrypi/controller/rpi/agc.hpp    | 34 +++----\n src/ipa/raspberrypi/controller/rpi/lux.cpp    | 17 ++--\n src/ipa/raspberrypi/controller/rpi/lux.hpp    |  4 +-\n src/ipa/raspberrypi/raspberrypi.cpp           | 69 ++++++++-------\n src/libcamera/utils.cpp                       | 41 +++++++++\n 13 files changed, 239 insertions(+), 120 deletions(-)"}