{"id":11621,"url":"https://patchwork.libcamera.org/api/1.1/covers/11621/?format=json","web_url":"https://patchwork.libcamera.org/cover/11621/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210318125521.43278-1-jacopo@jmondi.org>","date":"2021-03-18T12:55:19","name":"[libcamera-devel,0/2] libcamera: Do not default the location property","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/cover/11621/mbox/","series":[{"id":1802,"url":"https://patchwork.libcamera.org/api/1.1/series/1802/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1802","date":"2021-03-18T12:55:19","name":"libcamera: Do not default the location property","version":1,"mbox":"https://patchwork.libcamera.org/series/1802/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/11621/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D4301C32E1\n\tfor ;\n\tThu, 18 Mar 2021 12:54:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2317468D60;\n\tThu, 18 Mar 2021 13:54:55 +0100 (CET)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C649B602DB\n\tfor ;\n\tThu, 18 Mar 2021 13:54:53 +0100 (CET)","from uno.homenet.telecomitalia.it\n\t(host-79-22-58-175.retail.telecomitalia.it [79.22.58.175])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 1C7221BF204;\n\tThu, 18 Mar 2021 12:54:52 +0000 (UTC)"],"X-Originating-IP":"79.22.58.175","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 18 Mar 2021 13:55:19 +0100","Message-Id":"<20210318125521.43278-1-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.30.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 0/2] libcamera: Do not default the\n\tlocation property","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello,\n we've been discussion about how to handle the camera location\nproperly in libcamera and Android HAL.\n\nThe current setup\n- defaults location to External in libcamera if the fw does not provide that\n- sets FRONT if location is External in Android Camera HAL\n\nThis will make very complex to discern in future if a camera is actually\nexternal once the camera HAL will support the EXTERNAL HW level.\n\nTo simplify this and make it easier to fallback to a getting location from\na configuration file in the Camera HAL:\n- Do not report property::Location in libcamera if not available in fw\n- Do not default External to FRONT in HAL\n- To maintain compatibility with Android set location to FRONT if not available\n from the library in the Camera HAL.\n\nNo regressions in CTS testing.\n\nThanks\n j\n\nJacopo Mondi (2):\n libcamera: camera_sensor: Do not register Location if not available\n android: camera_device: Do not default External to Front\n\n src/android/camera_device.cpp | 6 +-----\n src/libcamera/camera_sensor.cpp | 6 ++----\n 2 files changed, 3 insertions(+), 9 deletions(-)\n\n--\n2.30.0"}