{"id":11600,"url":"https://patchwork.libcamera.org/api/1.1/covers/11600/?format=json","web_url":"https://patchwork.libcamera.org/cover/11600/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210317100211.1067585-1-naush@raspberrypi.com>","date":"2021-03-17T10:02:04","name":"[libcamera-devel,0/7] Raspberry Pi: ipa::init() restructuring","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"mbox":"https://patchwork.libcamera.org/cover/11600/mbox/","series":[{"id":1799,"url":"https://patchwork.libcamera.org/api/1.1/series/1799/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1799","date":"2021-03-17T10:02:06","name":"Raspberry Pi: ipa::init() restructuring","version":1,"mbox":"https://patchwork.libcamera.org/series/1799/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/11600/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 372A9BD80C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 17 Mar 2021 10:02:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C31FA6084D;\n\tWed, 17 Mar 2021 11:02:22 +0100 (CET)","from mail-ej1-x636.google.com (mail-ej1-x636.google.com\n\t[IPv6:2a00:1450:4864:20::636])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9AE8268D60\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Mar 2021 11:02:20 +0100 (CET)","by mail-ej1-x636.google.com with SMTP id mm21so1559837ejb.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Mar 2021 03:02:20 -0700 (PDT)","from naush-laptop.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tp24sm12061179edt.5.2021.03.17.03.02.16\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 17 Mar 2021 03:02:16 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Iql9HoVv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=mfZ0d23pe5IarOaf9BIvzhVc0gMs567KtpB958J/pyI=;\n\tb=Iql9HoVvDfO/6jq9gjHc10tSk7Pr2RD+nDm9O3jPvVMFhzjddIKysgmjuzgoGQ/nQX\n\tUDNxQu2INkkg9dBESrU6S9VCHaQq9hdMPM4TwUWplUlK7noKFV4sBiN4JtmmFVQad90W\n\tsnvPxyvfuAXiu++1+Suhb9dOg8udo9k/1Sm0cHO53+j2VV7H+zMdFjwcjeWcO1UwTtuq\n\tI9A13N9bcfwVqchbwNjdt7uRhZJa4GsnfrA+5+RdSHLo7gOlyKHavANNVuK3BPNujT3P\n\tysaunGS0NgnBJToHmxGbSIRcaMKHPvgqtbiC4IZwYf3cfotAuC4BnhIuhNptaxkforFI\n\tKAHg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=mfZ0d23pe5IarOaf9BIvzhVc0gMs567KtpB958J/pyI=;\n\tb=g453aYv9HnhetTZLg4mlLLDYqjQeCC1cJqwE+IvEplvQSnf3lak+tjjyfDExLejm7k\n\ttvmWHgmd+offjQyk4rYKMXbeBR3NqRI1WupBREI8v3JWF5W+RUg8rtemPY46kfhAUKhV\n\tq7WHmWdwCJYhD7384yZsHslTU+VhMPOdkXcZCloSwu9HQ6PQBlCBB0tOc5oOCwcquxK8\n\tajO9q9c2zb79OkvMPr0uBcrMvfbhQJCmYXLqTLMizlAwORXPNAsIxr9vikP4VBQb8ief\n\tA5rXRe3wORiefEzCmV0/yy0fOR7A2h4xj5fEGyVFXC+MzLlfZg6KNl6jTN4OQpQOQ6P5\n\tKdZQ==","X-Gm-Message-State":"AOAM533CX1Iyr+Snc6oau43A1wut4mTKU1vuSVmpK+qFGyj/RlNj71Rd\n\tTANx75Ca2eUqC+J7aGDTiokq3L+2rKrliA==","X-Google-Smtp-Source":"ABdhPJysw2kQZ/ik6ckGyEUUIU3/qOI3MIZNRHWppn1NXOTkQdMiCWcdRMdMC6gcBzQIsgHzuxjYMw==","X-Received":"by 2002:a17:906:35cf:: with SMTP id\n\tp15mr34203641ejb.379.1615975337214; \n\tWed, 17 Mar 2021 03:02:17 -0700 (PDT)","From":"Naushir Patuck <naush@raspberrypi.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 17 Mar 2021 10:02:04 +0000","Message-Id":"<20210317100211.1067585-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 0/7] Raspberry Pi: ipa::init()\n\trestructuring","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Hi,\n\nThis series uses Paul's recent work and moves some initialisation code from ipa::configure()\ninto ipa::init().  As a consequence, the pipeline handler is now able to selectively open\nthe Unicam embedded data node in pipeline_handler::match(), removing some of the existing\nugliness in dealing with opening this node.\n\nBrief patch breakdown:\n\nPatch 1/7: Adds the sensor model string to IPASettings.\nPatch 2/7: Moves the CamHelper initialise to ipa::init().\nPatch 3/7: Conditionally open the embedded data node in pipeline_handler::match().\nPatch 4/7: Move controller initialise to ipa::init().\nPatches 5/7 - 7/7: Some tidy-ups (remove unused member variables, some renaming) after the above refactoring.\n\nThanks,\nNaush\n\nNaushir Patuck (7):\n  ipa: Add sensor model string to IPASettings\n  pipeline: ipa: raspberrypi: Open the CamHelper on ipa::init()\n  pipeline: raspberrypi: Conditionally open the embedded data node\n  ipa: raspberrypi: Move the controller initialise to ipa::init()\n  ipa: raspberrypi: Remove unused member variables\n  ipa: raspberrypi: Rationalise parameters to ipa::start()\n  ipa: raspberrypi: Rationalise parameters to ipa::configure()\n\n include/libcamera/ipa/core.mojom              |   8 ++\n include/libcamera/ipa/raspberrypi.mojom       |  27 ++--\n src/ipa/raspberrypi/raspberrypi.cpp           | 110 +++++++--------\n .../pipeline/raspberrypi/raspberrypi.cpp      | 128 ++++++++----------\n src/libcamera/pipeline/vimc/vimc.cpp          |   2 +-\n test/ipa/ipa_interface_test.cpp               |   2 +-\n 6 files changed, 119 insertions(+), 158 deletions(-)"}