{"id":11569,"url":"https://patchwork.libcamera.org/api/1.1/covers/11569/?format=json","web_url":"https://patchwork.libcamera.org/cover/11569/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210312130304.34698-1-jeanmichel.hautbois@ideasonboard.com>","date":"2021-03-12T13:03:02","name":"[libcamera-devel,0/2] Prepare IPU3 pipeline to pass BDS to IPA","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/1.1/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/11569/mbox/","series":[{"id":1787,"url":"https://patchwork.libcamera.org/api/1.1/series/1787/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1787","date":"2021-03-12T13:03:02","name":"Prepare IPU3 pipeline to pass BDS to IPA","version":1,"mbox":"https://patchwork.libcamera.org/series/1787/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/11569/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C51F5BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Mar 2021 13:03:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BFE1868C69;\n\tFri, 12 Mar 2021 14:03:09 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B11668AA1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Mar 2021 14:03:08 +0100 (CET)","from localhost.localdomain (unknown\n\t[IPv6:2a01:e0a:169:7140:ddbd:a3a3:e47b:e390])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2ECCEA2A;\n\tFri, 12 Mar 2021 14:03:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"q8kro43W\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615554188;\n\tbh=mqh+5ZAmLbQ19lAzu8PPxPNq7T8HcfKg7xelx8AsLbY=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=q8kro43WBI/f1YmQzTqcINO0lr+VXCihj8HDRnTTQQeA5kNIRpa5PBhaAaf7m/bhL\n\tydw/DkyIVU+9XGuiJXkrp7dME3RFuCSfhGlOD+ZD5EldlY4zPmdLYLZZKKfdDy5swD\n\t5JiydGqIeHN+Oyin7BiATGtGkz9Vo84bXMJ0xrqU=","From":"Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 12 Mar 2021 14:03:02 +0100","Message-Id":"<20210312130304.34698-1-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 0/2] Prepare IPU3 pipeline to pass BDS to\n\tIPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"As said in patch [1/2] the IPA will need to use the BDS configuration\nbecause it configures a grid to get AWB statistics from the firmware.\nThose statistics are then used to apply a bunch of parameters.\n\nThis is one fast and easy way to do it, but probably not the best call.\nThe main issue is probably removing the 'const' from data_ in\nIPU3CameraConfiguration.\n\nAs I need the BDS to continue my AWB/AGC implementation, and don't want\nto be blocked for too long, I am using this for the moment :-).\n\nJean-Michel Hautbois (2):\n  libcamera: ipu3: Move Imgu configuration to IPU3CameraData\n  libcamera: ipu3: Pass the BDS rectangle at IPA configure call\n\n include/libcamera/ipa/ipu3.mojom     |  2 +-\n src/ipa/ipu3/ipu3.cpp                |  7 +++++--\n src/libcamera/pipeline/ipu3/ipu3.cpp | 17 ++++++++++-------\n 3 files changed, 16 insertions(+), 10 deletions(-)"}