{"id":11060,"url":"https://patchwork.libcamera.org/api/1.1/covers/11060/?format=json","web_url":"https://patchwork.libcamera.org/cover/11060/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210129151154.1051163-1-naush@raspberrypi.com>","date":"2021-01-29T15:11:48","name":"[libcamera-devel,v5,0/6] Raspberry Pi: Colour denoise","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"mbox":"https://patchwork.libcamera.org/cover/11060/mbox/","series":[{"id":1627,"url":"https://patchwork.libcamera.org/api/1.1/series/1627/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1627","date":"2021-01-29T15:11:48","name":"Raspberry Pi: Colour denoise","version":5,"mbox":"https://patchwork.libcamera.org/series/1627/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/11060/comments/","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9650ABD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 29 Jan 2021 15:12:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 05131683B2;\n\tFri, 29 Jan 2021 16:12:01 +0100 (CET)","from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n\t[IPv6:2a00:1450:4864:20::32b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DD4E6683A2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 29 Jan 2021 16:11:58 +0100 (CET)","by mail-wm1-x32b.google.com with SMTP id o10so7219166wmc.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 29 Jan 2021 07:11:58 -0800 (PST)","from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tf13sm6517461wmf.1.2021.01.29.07.11.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 29 Jan 2021 07:11:57 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"dVSHAAKe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=YQP3LOFLsBENigtCrJwP4h3MA5BtKurRNr3nDZD0GAE=;\n\tb=dVSHAAKePmdRsoLLyQ7lMhQjZtScl2msJ+sNs5KNy5n5hJJX8wt0Wsr/Z2O+IyK1y0\n\t7aHbpAReN0406Qj4mHvI3j94H2v3MxLxHRRO9JZV9GrqG65oLnnQrSSbNYT+tNiARQL3\n\tXuDbymCxAQJxXn5HtBiT9hslUl5+Dpj1Z8fxKPfSRx6QC+iT94f+39idfM/SoxrZobO6\n\tDQiR3IPB1SPmYArWIXB+UQa5QQo5tR96jVFKwQH5cKn0oXFPcd5FXzEHeyIp8Qkeh0Wb\n\tZ0/Nyr1osRd5EVGINDudI7B83t8UaQXh2JwUtccv94bfSwXK1Hb+DBDuMk42dhaZCfHT\n\t8ZPw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=YQP3LOFLsBENigtCrJwP4h3MA5BtKurRNr3nDZD0GAE=;\n\tb=iTXBhmDJIDUAcLlMCoqtj6HwRW8Bqd6+bgZA2ez7i7vgRbBtjQNPye0zcbwmPAP6tY\n\ts6B/3KLcP4QRSTOVXTgEDQK0U+ABJ8EImSZOaO8PouH4QspfvRASAJaLP+etJxGUtN0t\n\teW+TtC1ds5DWn9pCip1qp+Y5DIHvXlqMSYq2T7XLD5MMBmqIZ/d68g8MmH+p3HXq7a8o\n\ttA7CkRiBkx2mX8hz5fnkv/JDGOhkbkCUS+2YOW7DQAiuO8CFLmrSMiIkGAkI/aIHkqJ3\n\tTuaup94aFM2SXx6md7tYB3i3h6kLoFQAob39Eo+4rJn7y/eAB6cKXEcX1/UMdMTbbz2f\n\tOU+w==","X-Gm-Message-State":"AOAM5328qnWrthUNMBFNKvUFM8O2wLFq0FnAIl5AAldbnaSwfEQRBKMi\n\t5x+4NwpLFau4FwcupxTluiNcao0Xbx5mksNj","X-Google-Smtp-Source":"ABdhPJzrR9Ule/gjEYa08Ethjl69QfNaLDeZtqkPZh1j3jm2QxYRvY4iGkg5wH/qVYGZ5VuvxFvokg==","X-Received":"by 2002:a1c:c903:: with SMTP id f3mr4212517wmb.69.1611933118178; \n\tFri, 29 Jan 2021 07:11:58 -0800 (PST)","From":"Naushir Patuck <naush@raspberrypi.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 29 Jan 2021 15:11:48 +0000","Message-Id":"<20210129151154.1051163-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v5 0/6] Raspberry Pi: Colour denoise","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Hi,\n\nVersion 5 of this patch series addresses all the review comments in v4:\n- Switch DenoiseMode to an enum class.\n- Avoid double lookup in the DenoiseMode conversion table.\n- Add controls::draft::NoiseReductionMode to the available controls handled by the IPA.\n\nRegards,\nNaush\n\n\nNaushir Patuck (6):\n  pipeline: raspberrypi: Refactor stream configuration routine\n  pipeline: raspberrypi: Set the ISP Output1 to 1/4 resolution if unused\n  uapi: raspberrypi: Update the bcm2835-isp header definition\n  ipa: raspberrypi: Rename SdnStatus to DenoiseStatus\n  ipa: raspberrypi: Add a DenoiseAlgorithm class to the Controller\n  ipa: raspberrypi: Handle control::NoiseReductionMode in the controller\n\n include/libcamera/ipa/raspberrypi.h           |  1 +\n include/linux/bcm2835-isp.h                   | 32 ++++++-\n .../controller/denoise_algorithm.hpp          | 23 +++++\n .../{sdn_status.h => denoise_status.h}        |  7 +-\n src/ipa/raspberrypi/controller/rpi/sdn.cpp    | 17 ++--\n src/ipa/raspberrypi/controller/rpi/sdn.hpp    |  5 +-\n src/ipa/raspberrypi/raspberrypi.cpp           | 59 +++++++++++--\n .../pipeline/raspberrypi/raspberrypi.cpp      | 86 ++++++++++---------\n 8 files changed, 174 insertions(+), 56 deletions(-)\n create mode 100644 src/ipa/raspberrypi/controller/denoise_algorithm.hpp\n rename src/ipa/raspberrypi/controller/{sdn_status.h => denoise_status.h} (62%)"}