{"id":10794,"url":"https://patchwork.libcamera.org/api/1.1/covers/10794/?format=json","web_url":"https://patchwork.libcamera.org/cover/10794/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201231155336.7058-1-sebastian.fricke.linux@gmail.com>","date":"2020-12-31T15:53:32","name":"[libcamera-devel,v2,0/4] Improve BayerFormat class","submitter":{"id":73,"url":"https://patchwork.libcamera.org/api/1.1/people/73/?format=json","name":"Sebastian Fricke","email":"sebastian.fricke.linux@gmail.com"},"mbox":"https://patchwork.libcamera.org/cover/10794/mbox/","series":[{"id":1564,"url":"https://patchwork.libcamera.org/api/1.1/series/1564/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1564","date":"2020-12-31T15:53:32","name":"Improve BayerFormat class","version":2,"mbox":"https://patchwork.libcamera.org/series/1564/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/10794/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A6084C0F1A\n\tfor ;\n\tThu, 31 Dec 2020 15:54:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 34ECD615B2;\n\tThu, 31 Dec 2020 16:54:25 +0100 (CET)","from mail-wr1-x430.google.com (mail-wr1-x430.google.com\n\t[IPv6:2a00:1450:4864:20::430])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BD3A16031B\n\tfor ;\n\tThu, 31 Dec 2020 16:54:23 +0100 (CET)","by mail-wr1-x430.google.com with SMTP id r3so20409592wrt.2\n\tfor ;\n\tThu, 31 Dec 2020 07:54:23 -0800 (PST)","from basti-TUXEDO-Book-XA1510.fritz.box\n\t(p200300d1ff267500b10aabf0e84cdf75.dip0.t-ipconnect.de.\n\t[2003:d1:ff26:7500:b10a:abf0:e84c:df75])\n\tby smtp.gmail.com with ESMTPSA id\n\ts63sm14595787wms.18.2020.12.31.07.54.22\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 31 Dec 2020 07:54:22 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"k+HxCSng\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=snslqTIDVJgc40ytGaQeRYGbGg9Iy8GeRpOrp+4ixag=;\n\tb=k+HxCSngktPH2bdkGWkSUt4zK8vVGMS1nIEX+mSBEyaNAqeKfBBl0b2mezGUWgR4q9\n\tQFSCUENgarD2Mavc8lKlvlCmBMSfNHyx83meoK/ntHLze838Iq5b8cRZoK+ZdNT3bZn2\n\ttFvAGmhNO/YcNzzn4Rz+lRSec5ZDOfyqmfZm9ZSWWZZDiMEL99Jg8Xc1rD5gG02/dk0G\n\tRFOlGCoi4ba2kfRVxoDMq9RAMpGMJeaSZYjnBxn638lD94A+NrqsEzi1wZq+eYzVYzbk\n\tfL8GCGXntxbyssw8TFn+QTSxJaH52SEgOLCoNZBBIKaIiFKAQbCSM5FDmpPpEF3VHb98\n\tkD3A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=snslqTIDVJgc40ytGaQeRYGbGg9Iy8GeRpOrp+4ixag=;\n\tb=cpmgbPWgqCIT6vJX4EZFnPIFtKvzcnLMorvbvzWa1ohd7Wm+h5ezgXPfjuzzLT+gEs\n\tAu1qvHw96zJZksR2hPoE65JFq0R5Kw7y0tKzYQP7aLJoTuh4j6q8QsQlxtKHJrjmfilt\n\tVHUDtVYTGS9chpSKMMz7pe1mpTFdVrexp/CGJl52rEanXDjmJ5bVwX/1/MUiGZsgd0SE\n\t0+4Zdb21MP6nTXdGMS8qj3mLFBCzHbmSZIXWCfqDUo9fsUiv3Bu7L7ps6BFFQ5JSxSEM\n\t0ODOEfdCxFwVsrr4D0ShEt0juuvJ5fQKEDeLSYCpdxzDTagcxodwVKK8C/5FrI+I5c+v\n\tgjtw==","X-Gm-Message-State":"AOAM53138Twh/UDibAIPE5Ogcp/6K9trnctrZhW9CD84RRVAaXvsBbkS\n\twUPYr7gL4fYfpSvSWFxPi0to7HNsLrQ=","X-Google-Smtp-Source":"ABdhPJxgDqPC+FOmP4HAqFCkWniQK2FTR9Vq9U7F87LZ7cWQYTQDKEPoFLxxYufhobE7w9YCNyzG/A==","X-Received":"by 2002:a05:6000:1d2:: with SMTP id\n\tt18mr54266458wrx.412.1609430063416; \n\tThu, 31 Dec 2020 07:54:23 -0800 (PST)","From":"Sebastian Fricke ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 31 Dec 2020 16:53:32 +0100","Message-Id":"<20201231155336.7058-1-sebastian.fricke.linux@gmail.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 0/4] Improve BayerFormat class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Improve BayerFormat class\n\nThis patch series adds unit-tests, the `fromV4L2PixelFormat` static\nmember function and the ==/!= operators to the BayerFormat class.\n\n---\n\nChanges since version 1:\n* Convert the `fromV4L2PixelFormat` to a static member function, as it doesn't\n contain any self use.\n* Adjust the current user of the old constructor (raspberryPi pipeline) to use\n the new function.\n* Add the ==/!= operators to improve tests and to add helpful helper functions.\n* Change the logic of `fromV4L2PixelFormat` by replace the search of a matching\n bayer format to a v4l2 pixel format with a search for a matching v4l2 pixel\n format to a bayer format.\n* Remove the v4l2ToBayer mapping table as it lost it's last user\n* Remove 'TEST \\d:' & 'TEST \\d: FAIL:' pattern from comments and messages\n within the unit tests.\n* Convert variable names from snake_case to camelCase.\n* Add an additional to test to confirm that we cannot get a V4L2PixelFormat\n from a BayerFormat not found in the mapping table.\n* Add tests for the == & != operators\n* Change the test within the Transform unit tests from a comparision of string\n formats to a direct compare of the BayerFormat objects.\n* Unify the test error messages by enclosing the expected and actual string\n representations in ''\n* Fix checkstyle errors.\n* Add explaination for why the transpose functionality was ignored\n within the unit test.\n\n---\n\nSebastian Fricke (4):\n libcamera: Add the fromV4L2PixelFormat function\n libcamera: Overload ==/!= operators for BayerFormats\n libcamera: pipeline: rpi: Adjust to new implementation\n test: Add unit tests for the BayerFormat class\n\n include/libcamera/internal/bayer_format.h | 8 +\n src/libcamera/bayer_format.cpp | 73 +++----\n .../pipeline/raspberrypi/raspberrypi.cpp | 4 +-\n test/bayer_format.cpp | 202 ++++++++++++++++++\n test/meson.build | 1 +\n 5 files changed, 241 insertions(+), 47 deletions(-)\n create mode 100644 test/bayer_format.cpp"}