{"id":10657,"url":"https://patchwork.libcamera.org/api/1.1/covers/10657/?format=json","web_url":"https://patchwork.libcamera.org/cover/10657/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201212185116.29611-1-laurent.pinchart@ideasonboard.com>","date":"2020-12-12T18:51:13","name":"[libcamera-devel,0/3] libcamera: Fix leaks and simplify object management with std::unique_ptr<>","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/10657/mbox/","series":[{"id":1531,"url":"https://patchwork.libcamera.org/api/1.1/series/1531/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1531","date":"2020-12-12T18:51:14","name":"libcamera: Fix leaks and simplify object management with std::unique_ptr<>","version":1,"mbox":"https://patchwork.libcamera.org/series/1531/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/10657/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D7E70BD80A\n\tfor ;\n\tSat, 12 Dec 2020 18:51:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 023F0605BF;\n\tSat, 12 Dec 2020 19:51:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DA0916032B\n\tfor ;\n\tSat, 12 Dec 2020 19:51:26 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4CCD396\n\tfor ;\n\tSat, 12 Dec 2020 19:51:26 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rbyeojfr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1607799086;\n\tbh=L0G4387GGHyzIwKCbIEGE3XhEEMgZCN846owPFd4fSc=;\n\th=From:To:Subject:Date:From;\n\tb=rbyeojfrkClUW2N5xylkSTTdy/Yv9diIUwwQ+mj32m3uzh9mJHsxNflvro38bPR1O\n\t+MtB00Lp0inBM0RKKuSnJwIlVkNAkD6IQhnYQ90L3Do8Lyt/MjGzn+q2hGI5+CFkuc\n\t/bBVIx9iI2NgGvg6R2IERJPXKEpkfYLjcTL5Y3sc=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 12 Dec 2020 20:51:13 +0200","Message-Id":"<20201212185116.29611-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 0/3] libcamera: Fix leaks and simplify\n\tobject management with std::unique_ptr<>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello,\n\nThis small patch series is a follow-up of the switch of\nV4L2*::fromEntityName() to std::unique_ptr<>. It replaces more manually\nmanaged pointers with std::unique_ptr<> in pipeline handlers, including\nexpanding usage of V4L2*::fromEntityName(). I've noticed a memory leak\nwhile writing the code, which is fixed in patch 1/3.\n\nLaurent Pinchart (3):\n libcamera: pipeline: raspberrypi: Don't leak RPiCameraData::sensor_\n libcamera: pipeline: vimc: Use V4L2*::fromEntityName() where possible\n libcamera: pipeline: Manage resources with std::unique_ptr<>\n\n src/libcamera/pipeline/ipu3/cio2.cpp | 11 ++-----\n src/libcamera/pipeline/ipu3/cio2.h | 9 +++--\n .../pipeline/raspberrypi/raspberrypi.cpp | 7 ++--\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 19 ++++-------\n src/libcamera/pipeline/simple/converter.cpp | 8 +----\n src/libcamera/pipeline/simple/converter.h | 3 +-\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 12 +++----\n src/libcamera/pipeline/vimc/vimc.cpp | 33 +++++++------------\n 8 files changed, 34 insertions(+), 68 deletions(-)"}