{"id":10330,"url":"https://patchwork.libcamera.org/api/1.1/covers/10330/?format=json","web_url":"https://patchwork.libcamera.org/cover/10330/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201104074841.21676-1-laurent.pinchart@ideasonboard.com>","date":"2020-11-04T07:48:38","name":"[libcamera-devel,v2,0/3] libcamera: Fix uninitialized use of V4L2DeviceFormat members","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/10330/mbox/","series":[{"id":1443,"url":"https://patchwork.libcamera.org/api/1.1/series/1443/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1443","date":"2020-11-04T07:48:38","name":"libcamera: Fix uninitialized use of V4L2DeviceFormat members","version":2,"mbox":"https://patchwork.libcamera.org/series/1443/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/10330/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4641CBE080\n\tfor ;\n\tWed, 4 Nov 2020 07:49:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C190462BC9;\n\tWed, 4 Nov 2020 08:49:34 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6B9F260344\n\tfor ;\n\tWed, 4 Nov 2020 08:49:33 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EC353563\n\tfor ;\n\tWed, 4 Nov 2020 08:49:32 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OcXU3qxK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604476173;\n\tbh=Xlb6pjUgn/lhuJdTdvYD7VNhw0Bes1mCHzgS11w/FCk=;\n\th=From:To:Subject:Date:From;\n\tb=OcXU3qxKNfSw3fANjDi23xnY5BNL7Gfye4vCFgBOTyRCgPT7GxhZD5lim7qSCWkze\n\t5Ng7KQT9auoYDlklMps0Vg+/YqcP9z7k5T6F0Sv0snxDrHpTmKjtNYz3lkPdH6Cm1/\n\tO++WfbdcNetRQfc9yV25pojH9KvKcUZXYuI+etzY=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 4 Nov 2020 09:48:38 +0200","Message-Id":"<20201104074841.21676-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 0/3] libcamera: Fix uninitialized use\n\tof V4L2DeviceFormat members","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Hello,\n\nThis small series fixes uninitialized uses of planes and planesCount\nmembers of the V4L2DeviceFormat class. It supersedes the following two\npatches (hence the v2):\n\n[PATCH 1/2] libcamera: v4l2_videodevice: Check plane count when setting format\n[PATCH 2/2] libcamera: pipeline: simple: Initialize V4L2DeviceFormat before use\n\nThe approach taken here is different, instead of adding missing\ninitialization in the users of the class, and starting a game of\nwhack-a-mole, patch 1/3 adds initializers in the class itself. Patch 2/3\nhasn't changed compared to 1/2 of v1, and patch 3/3 drops now unneeded\nexplicit initialization.\n\nThe series has been tested by removing patch 1/3, noticing assertion\nfailures in unit tests, and verifying that patch 1/3 fixes the issue.\n\nLaurent Pinchart (3):\n libcamera: v4l2_videodevice: Zero-initialize planes in\n V4L2DeviceFormat\n libcamera: v4l2_videodevice: Check plane count when setting format\n libcamera: Drop unnecessary explicit initialization of\n V4L2DeviceFormat\n\n include/libcamera/internal/v4l2_videodevice.h | 13 ++++++++-----\n src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 6 +++---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 ++--\n src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 4 ++--\n src/libcamera/pipeline/simple/converter.cpp | 2 +-\n src/libcamera/pipeline/simple/simple.cpp | 4 ++--\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 4 ++--\n src/libcamera/pipeline/vimc/vimc.cpp | 4 ++--\n src/libcamera/v4l2_videodevice.cpp | 11 +++++++++++\n 10 files changed, 34 insertions(+), 20 deletions(-)"}