{"id":10252,"url":"https://patchwork.libcamera.org/api/1.1/covers/10252/?format=json","web_url":"https://patchwork.libcamera.org/cover/10252/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201026140134.44166-1-email@uajain.com>","date":"2020-10-26T14:01:31","name":"[libcamera-devel,0/3] android: jpeg: exif: Embed a JPEG-encoded thumbnail","submitter":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/people/1/?format=json","name":"Umang Jain","email":"email@uajain.com"},"mbox":"https://patchwork.libcamera.org/cover/10252/mbox/","series":[{"id":1416,"url":"https://patchwork.libcamera.org/api/1.1/series/1416/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1416","date":"2020-10-26T14:01:31","name":"android: jpeg: exif: Embed a JPEG-encoded thumbnail","version":1,"mbox":"https://patchwork.libcamera.org/series/1416/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/10252/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3E373BDB13\n\tfor ;\n\tMon, 26 Oct 2020 14:02:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 87F5361E5F;\n\tMon, 26 Oct 2020 15:02:34 +0100 (CET)","from mail.uajain.com (static.126.159.217.95.clients.your-server.de\n\t[95.217.159.126])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A74E6034E\n\tfor ;\n\tMon, 26 Oct 2020 15:02:32 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"SeO9BwqD\"; dkim-atps=neutral","From":"Umang Jain ","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail;\n\tt=1603720951; bh=8c9Ko6jwc94kdp3OdqXqzB85vWzwgsp7BzF9czQuzDA=;\n\th=From:To:Cc:Subject;\n\tb=SeO9BwqDCNZv/ECrQqjnGzyrB3Xvui3FGYpqxAGzYQrH4RUVW3rDDplr41MGCyxhx\n\t2z/UPT6AkYeHmdbQNuInBjS/cQb9gyB/80cvkoxodS1t65Uq1v8AFrOHJInyN+vQL6\n\trG29UNU2jEfPbjFjwpT6Po31TtiTShG+vIIMvoAMIDY59B8FEcDKhabA91B3pszeGf\n\tTbblkplyww6fY3NkQp8qMampTrHVA2Ud0Q1BTZbMxZoA91Xgcf3mrfsXvIeeqjTXpW\n\tNcwWFUdTj0sHFLkNGaykeHGja3j6FmWzqRnT9wqJad4hLfMaY6ZpZwHNAI1pm7BDUa\n\teT01ZfUAUdAJQ==","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 26 Oct 2020 19:31:31 +0530","Message-Id":"<20201026140134.44166-1-email@uajain.com>","Mime-Version":"1.0","Subject":"[libcamera-devel] [PATCH 0/3] android: jpeg: exif: Embed a\n\tJPEG-encoded thumbnail","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"After refactoring the jpeg encoder bits and introducing a new\nPostProcessor interface, it's time to introduce a simple image\nthumbnailer to thumbnail the frames captured and embed it via libexif.\n\nThe patches have been tested locally via vivid PH/cam-file-sink, so\nthere is some level of confidence in the patches. If anyone is interested,\nI can provide a wip: branch which I used. There were some tweaks to use\nthe PostProcessor (instead of the encoder directly) but nothing major.\n\nPatch 1/3 is simply a bugfix I encountered when testing the patches.\nPatch 2/3 has been reviewed and approved before, when the PostProcessor\nand Encoder had some new function signatures changes recently hence,\nI thought that it's best to drop the review tags and ask for a re-review.\nPatch 3/3 is the actual meat of this series, which in my opinion has been\nquite simplified after a lot of churn (finally!).\n\nThanks!\n\nUmang Jain (3):\n android: jpeg: Return encoded bytes size from PostProcessorJpeg\n android: jpeg: encoder_libjpeg: Allow encoding raw frame bytes\n android: jpeg: exif: Embed a JPEG-encoded thumbnail\n\n src/android/jpeg/encoder_libjpeg.cpp | 18 ++--\n src/android/jpeg/encoder_libjpeg.h | 7 +-\n src/android/jpeg/exif.cpp | 16 +++-\n src/android/jpeg/exif.h | 1 +\n src/android/jpeg/post_processor_jpeg.cpp | 37 +++++++-\n src/android/jpeg/post_processor_jpeg.h | 8 +-\n src/android/jpeg/thumbnailer.cpp | 109 +++++++++++++++++++++++\n src/android/jpeg/thumbnailer.h | 37 ++++++++\n src/android/meson.build | 1 +\n 9 files changed, 222 insertions(+), 12 deletions(-)\n create mode 100644 src/android/jpeg/thumbnailer.cpp\n create mode 100644 src/android/jpeg/thumbnailer.h"}