{"id":10077,"url":"https://patchwork.libcamera.org/api/1.1/covers/10077/?format=json","web_url":"https://patchwork.libcamera.org/cover/10077/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201016090014.64703-1-kieran.bingham@ideasonboard.com>","date":"2020-10-16T09:00:03","name":"[libcamera-devel,v3,00/11] Shadowed Variables","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/10077/mbox/","series":[{"id":1379,"url":"https://patchwork.libcamera.org/api/1.1/series/1379/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1379","date":"2020-10-16T09:00:03","name":"Shadowed Variables","version":3,"mbox":"https://patchwork.libcamera.org/series/1379/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/10077/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 77975BDB1F\n\tfor ;\n\tFri, 16 Oct 2020 09:00:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C9CDE610CC;\n\tFri, 16 Oct 2020 11:00:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BE22860532\n\tfor ;\n\tFri, 16 Oct 2020 11:00:18 +0200 (CEST)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3A707528;\n\tFri, 16 Oct 2020 11:00:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jlFHxcov\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602838818;\n\tbh=aTHYZfnNqKCCR9A3lXsCG+YMaOAAu5q3Cf+dw4MU0Ec=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=jlFHxcovo2jiinu17K+rUmG/nEX6xjtcpqqV9PRHro63WxTQIVSfnHA3XqituSuYt\n\tZuka2eDUZhTT38g3jWP360PM3V/5Jya4rab77wOBMq/3GJ/eY+M7FXW94GKQqcl/q/\n\tMGzRabY04YyU2KvqYkGoXgE56fAi1Hrlk3ebtGDs=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Fri, 16 Oct 2020 10:00:03 +0100","Message-Id":"<20201016090014.64703-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 00/11] Shadowed Variables","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Final spin of the shadowed variables series.\n\nMinor fixups mostly to renaming the use of the word 'alias' in this\nseries to be 'shadow'.\n\nAll tests pass, and I'll push this this evening or next week if no\nblockers are identified.\n\nKieran Bingham (11):\n cam: options: Rename optional arg to prevent shadowing\n qcam: main_window: Explicitly name raw buffer\n libcamera: thread: Prevent shadowing of signal name\n libcamera: pipeline: Prevent variable shadowing\n libcamera: pipeline: Use existing variable definitions\n libcamera: pipeline: rpi_stream: Explicitly name requestBuffer\n libcamera: v4l2_videodevice: Prevent shadowing of V4L2BufferCache\n members\n test: v4l2_videodevice: Prevent variable shadowing of format\n ipa: raspberrypi: Re-use iterator variable\n android: metadata: Disable -Wshadow\n meson: Enable shadowed variable warning\n\n include/libcamera/internal/v4l2_videodevice.h | 4 ++--\n meson.build | 1 +\n src/android/meson.build | 1 +\n src/cam/options.cpp | 10 +++++-----\n src/ipa/raspberrypi/controller/rpi/alsc.cpp | 6 +++---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 8 ++++----\n src/libcamera/pipeline/raspberrypi/rpi_stream.cpp | 8 ++++----\n src/libcamera/pipeline/simple/converter.cpp | 8 ++++----\n src/libcamera/pipeline/simple/simple.cpp | 8 ++++----\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 4 ++--\n src/libcamera/thread.cpp | 8 ++++----\n src/libcamera/v4l2_videodevice.cpp | 12 ++++++------\n src/qcam/main_window.cpp | 8 ++++----\n test/v4l2_videodevice/formats.cpp | 6 +++---\n 14 files changed, 47 insertions(+), 45 deletions(-)"}