{"id":10061,"url":"https://patchwork.libcamera.org/api/1.1/covers/10061/?format=json","web_url":"https://patchwork.libcamera.org/cover/10061/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201015223750.58563-1-kieran.bingham@ideasonboard.com>","date":"2020-10-15T22:37:39","name":"[libcamera-devel,v2,00/11] Shadowed Variables","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/cover/10061/mbox/","series":[{"id":1376,"url":"https://patchwork.libcamera.org/api/1.1/series/1376/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1376","date":"2020-10-15T22:37:39","name":"Shadowed Variables","version":2,"mbox":"https://patchwork.libcamera.org/series/1376/mbox/"}],"comments":"https://patchwork.libcamera.org/api/covers/10061/comments/","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3D619BE905\n\tfor ;\n\tThu, 15 Oct 2020 22:37:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1B5A761056;\n\tFri, 16 Oct 2020 00:37:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 683E2600F2\n\tfor ;\n\tFri, 16 Oct 2020 00:37:55 +0200 (CEST)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CA7BD556;\n\tFri, 16 Oct 2020 00:37:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"twdM7i5Y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602801475;\n\tbh=hDA+NquDKQjHyvZ7jM3ZDrnSe4kU1AELVIJBHvrL6pg=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=twdM7i5Y0uMn/Q4O6vetaMpsqEvw3bk6D7U3moFnnXyx2WDWg0XPPrcLfRVGvlr2z\n\tjQyVdOhYXG1W3dsXy8w+c8zrExIpBW89t9s7of8qSEqpuUnkjBqbWgvqO9ty89Brdr\n\ti/CWQT5AA0lggPIiZwkXlCu3PPb9z6PS34toAnPQ=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Thu, 15 Oct 2020 23:37:39 +0100","Message-Id":"<20201015223750.58563-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 00/11] Shadowed Variables","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"During development, I hit an awkward issue with a variable being aliased\nin the constructor, which caused horrendous pain debugging.\n\nWe can warn on shadowed variables to prevent this occuring and this\nseries introduces that.\n\n\nKieran Bingham (11):\n cam: options: Rename optional arg to prevent aliasing\n qcam: main_window: Explicitly name raw buffer\n libcamera: thread: Prevent aliasing of signal name\n libcamera: pipeline: Prevent variable aliasing\n libcamera: pipeline: Use existing variable definitions\n libcamera: pipeline: rpi_stream: Explicitly name requestBuffer\n libcamera: v4l2_videodevice: Prevent aliasing of V4L2BufferCache\n members\n test: v4l2_videodevice: Prevent variable aliasing of format\n ipa: raspberrypi: Re-use iterator variable\n android: metadata: Disable -Wshadow\n meson: Enable shadowed variable warning\n\n include/libcamera/internal/v4l2_videodevice.h | 4 ++--\n meson.build | 1 +\n src/android/meson.build | 1 +\n src/cam/options.cpp | 10 +++++-----\n src/ipa/raspberrypi/controller/rpi/alsc.cpp | 6 +++---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 8 ++++----\n src/libcamera/pipeline/raspberrypi/rpi_stream.cpp | 8 ++++----\n src/libcamera/pipeline/simple/converter.cpp | 8 ++++----\n src/libcamera/pipeline/simple/simple.cpp | 8 ++++----\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 4 ++--\n src/libcamera/thread.cpp | 8 ++++----\n src/libcamera/v4l2_videodevice.cpp | 12 ++++++------\n src/qcam/main_window.cpp | 8 ++++----\n test/v4l2_videodevice/formats.cpp | 6 +++---\n 14 files changed, 47 insertions(+), 45 deletions(-)"}